Fix spec:valgrind task by adopting ruby_memcheck#90
Merged
Watson1978 merged 3 commits intosocketry:mainfrom Mar 21, 2026
Merged
Fix spec:valgrind task by adopting ruby_memcheck#90Watson1978 merged 3 commits intosocketry:mainfrom
spec:valgrind task by adopting ruby_memcheck#90Watson1978 merged 3 commits intosocketry:mainfrom
Conversation
Watson1978
force-pushed
the
ruby_memcheck
branch
3 times, most recently
from
8a63490 to
4ca1038
Compare
Watson1978
force-pushed
the
ruby_memcheck
branch
from
4ca1038 to
eba1395
Compare
The existing `spec:valgrind` task fails with the following error on modern environments: `NameError: uninitialized constant RUBY` Instead of just fixing the outdated constant, this commit replaces the old custom Valgrind command builder with the `ruby_memcheck` gem. This modernizes the memory check process and automatically handles Valgrind suppressions for Ruby's internal memory allocations, making it much easier to detect actual memory leaks in the C extension.
Watson1978
force-pushed
the
ruby_memcheck
branch
from
eba1395 to
778b43d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing
spec:valgrindtask fails with the following error on modern environments:NameError: uninitialized constant RUBYInstead of just fixing the outdated constant, this commit replaces the old custom Valgrind command builder with the
ruby_memcheckgem. This modernizes the memory check process and automatically handles Valgrind suppressions for Ruby's internal memory allocations, making it much easier to detect actual memory leaks in the C extension.Types of Changes
Contribution