ext: allow epoll_pwait2 to be disabled via --disable-epoll_pwait2#159
Merged
ioquatix merged 1 commit intosocketry:mainfrom Mar 10, 2026
Merged
ext: allow epoll_pwait2 to be disabled via --disable-epoll_pwait2#159ioquatix merged 1 commit intosocketry:mainfrom
ioquatix merged 1 commit intosocketry:mainfrom
Conversation
maxlazio
pushed a commit
to gitlabhq/omnibus-gitlab
that referenced
this pull request
Mar 9, 2026
Some distributions (e.g. RedHat 9.7) ship glibc 2.34 with backported `epoll_pwait2` support tagged as `GLIBC_2.35`, causing binaries built there to fail on systems with a true glibc 2.34 (RedHat 9.6). This change: - Adds a new ruby-io-event software definition that rebuilds the io-event gem without the epoll_pwait2 check on RedHat 9 systems. - Adds the ruby-io-event dependency to the gitlab project for RedHat 9. - Adds a el_9? helper method to OhaiHelper for platform detection socketry/io-event#159 would avoid the need for this patching. Relates to https://gitlab.com/gitlab-com/request-for-help/-/work_items/4332
Member
|
How do we use this |
stanhu
force-pushed
the
sh-disable-epoll-wait2
branch
from
4ec7a0b to
5313496
Compare
Contributor
Author
I updated the description to show how to use this. |
Member
|
I understand the convention to use dashes, but I think it should be consistent with the name of the function, e.g. WDYT? |
maxlazio
pushed a commit
to gitlabhq/omnibus-gitlab
that referenced
this pull request
Mar 10, 2026
Some distributions (e.g. RedHat 9.7) ship glibc 2.34 with backported `epoll_pwait2` support tagged as `GLIBC_2.35`, causing binaries built there to fail on systems with a true glibc 2.34 (RedHat 9.6). This change: - Adds a new ruby-io-event software definition that rebuilds the io-event gem without the epoll_pwait2 check on RedHat 9 systems. - Adds the ruby-io-event dependency to the gitlab project for RedHat 9. - Adds a el_9? helper method to OhaiHelper for platform detection socketry/io-event#159 would avoid the need for this patching. Relates to https://gitlab.com/gitlab-com/request-for-help/-/work_items/4332
maxlazio
pushed a commit
to gitlabhq/omnibus-gitlab
that referenced
this pull request
Mar 10, 2026
Some distributions (e.g. RedHat 9.7) ship glibc 2.34 with backported `epoll_pwait2` support tagged as `GLIBC_2.35`, causing binaries built there to fail on systems with a true glibc 2.34 (RedHat 9.6). This change: - Adds a new ruby-io-event software definition that rebuilds the io-event gem without the epoll_pwait2 check on RedHat 9 systems. - Adds the ruby-io-event dependency to the gitlab project for RedHat 9. - Adds a el_9? helper method to OhaiHelper for platform detection socketry/io-event#159 would avoid the need for this patching. Relates to https://gitlab.com/gitlab-com/request-for-help/-/work_items/4332
Some distributions (e.g. RedHat 9.7) ship glibc 2.34 with backported epoll_pwait2 support tagged as GLIBC_2.35, causing binaries built there to fail on systems with a true glibc 2.34 (RedHat 9.6). Wrapping the have_func check in enable_config allows the caller to opt out at build time. If your system has a backported `epoll_pwait2` that causes portability issues, you can disable it at build time: ``` gem install io-event -- --disable-epoll_pwait2 ``` With `bundle`: ``` bundle config set build.io-event --disable-epoll_pwait2 bundle install ```
stanhu
force-pushed
the
sh-disable-epoll-wait2
branch
from
5313496 to
3ecc3ee
Compare
ioquatix
approved these changes
Mar 10, 2026
maxlazio
pushed a commit
to gitlabhq/omnibus-gitlab
that referenced
this pull request
Mar 10, 2026
Some distributions (e.g. RedHat 9.7) ship glibc 2.34 with backported `epoll_pwait2` support tagged as `GLIBC_2.35`, causing binaries built there to fail on systems with a true glibc 2.34 (RedHat 9.6). This change: - Adds a new ruby-io-event software definition that rebuilds the io-event gem without the epoll_pwait2 check on RedHat 9 systems. - Adds the ruby-io-event dependency to the gitlab project for RedHat 9. - Adds a el_9? helper method to OhaiHelper for platform detection socketry/io-event#159 would avoid the need for this patching. Relates to https://gitlab.com/gitlab-com/request-for-help/-/work_items/4332
stanhu
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some distributions (e.g. RedHat 9.7) ship glibc 2.34 with backported epoll_pwait2 support tagged as GLIBC_2.35, causing binaries built there to fail on systems with a true glibc 2.34 (RedHat 9.6). Wrapping the
have_funccheck inenable_configallows the caller to opt out at build time.If your system has a backported
epoll_pwait2that causes portability issues, you can disable it at build time:Or:
bundle config set build.io-event --disable-epoll_pwait2 bundle installTypes of Changes
Contribution