Add io_pread and io_pwrite methods to IO_Event_Selector_KQueue#162
Open
ItaloCobains wants to merge 3 commits intosocketry:mainfrom
Open
Add io_pread and io_pwrite methods to IO_Event_Selector_KQueue#162ItaloCobains wants to merge 3 commits intosocketry:mainfrom
ItaloCobains wants to merge 3 commits intosocketry:mainfrom
Conversation
…or improved readability and performance
7ebc088 to
596e472
Compare
There was a problem hiding this comment.
Pull request overview
This PR adds positional IO buffer operations (io_pread/io_pwrite) to the IO::Event::Selector::KQueue backend, aligning KQueue with other selectors that support IO::Buffer-based scheduler hooks.
Changes:
- Implement
IO_Event_Selector_KQueue_io_preadusingpread(2)with scheduler-aware retry viaio_wait. - Implement
IO_Event_Selector_KQueue_io_pwriteusingpwrite(2)with scheduler-aware retry viaio_wait. - Expose both methods to Ruby via
rb_define_methodwhenHAVE_RUBY_IO_BUFFER_His available.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of Changes
Contribution