Call xfree on TypedData_Make_Struct selectors#163
Merged
ioquatix merged 1 commit intosocketry:mainfrom Mar 24, 2026
Merged
Conversation
TypedData_Make_Struct uses Ruby's xmalloc internally, so the corresponding free functions should call xfree rather than free. Ruby's xmalloc tracks allocation size internally so the GC knows how much memory is in use. In most release builds this justs causes this memory to be missed in accounting (causing extra GCs). However in debug builds in ruby 4.1dev the mismatched operations may crash.
Member
|
Thanks, I didn't know it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TypedData_Make_Structuses Ruby'sxmallocinternally, so the corresponding free functions should callxfreerather thanfree.Ruby's
xmalloctracks allocation size internally so the GC knows how much memory is in use. In most release builds this just causes this memory to be missed in accounting (causing extra GCs). However in debug builds in Ruby 4.1dev the mismatched operations may crash.