Connection#close_write closes the connection on failure.#25
Merged
Conversation
ioquatix
force-pushed
the
close_write-rescue-closed
branch
from
264b36d to
03a98a6
Compare
ioquatix
force-pushed
the
close_write-rescue-closed
branch
from
03a98a6 to
c470fcb
Compare
There was a problem hiding this comment.
Pull request overview
Fixes issue #23 where Connection#close_write would propagate exceptions (e.g., Protocol::HTTP2::ProtocolError: Cannot send data in state: closed) when the underlying transport was already closed. The fix rescues those errors and transitions the connection to :closed state, matching the resilient behavior of close!.
Changes:
close_writenow rescues errors raised duringsend_closeand marks the connection as closed.- Added tests covering close_write on a closed stream (with and without error), and that successful close_write leaves the connection still readable/not closed.
- Added an Unreleased section to
releases.mddescribing the fix.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lib/protocol/websocket/connection.rb | Rescue exceptions in close_write and mark connection as closed. |
| test/protocol/websocket/connection.rb | New tests for close_write behavior on closed/open streams. |
| releases.md | Document the close_write resilience fix under Unreleased. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Possible fix for #23.
Types of Changes
Contribution