Fixed wrong CGSession used with the events posted (a case of multiple users)#97
Open
grigorye wants to merge 1 commit intosocsieng:mainfrom
Open
Fixed wrong CGSession used with the events posted (a case of multiple users)#97grigorye wants to merge 1 commit intosocsieng:mainfrom
grigorye wants to merge 1 commit intosocsieng:mainfrom
Conversation
41e9d2a to
95bafe4
Compare
Owner
|
Thanks for the PR. I'll do some testing in the next couple of days. Assuming all is good, I'll aim to get this merged by the end of this week. |
|
@socsieng Did you run into any problems when testing? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been using sendkeys to automate some testing inside VMs and discovered the following while trying to investigate why sendkeys "does nothing" in certain cases when I tried to employ multiple users in VM to benefit from some parallelization: basically it was not TCC problem, it did not complain about lack of permissions/the "Terminal" and etc was added there. Basically for some users (typically, the first logged in) it worked, while for the rest it silently did nothing (except for activating the app that was set as the destination).
Spent quite several hours trying to figure it out, and then accidentally encountered the case that is captured on the recording: basically, sendkeys is sending mouse clicks to a wrong user session. It turned out that it was matter of
.cghidEventTapvs.cgSessionEventTap. That explains everything and fixes the problem for me (you can see the effect at the recording where /tmp/sendkeys is used - that's something compiled with the change).The same problem is applicable to key presses (and is fixed as well).
(I did not try
.cgAnnotatedSessionEventTapbut I feel like.cgSessionEventTapdoes enough job.)sendkeys-wrong-session-demo.mp4