Skip to content

[WIP] Address feedback from review on merge ai_dev to master #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
soficis merged 2 commits into from
Feb 18, 2026
Merged

[WIP] Address feedback from review on merge ai_dev to master #5

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2eec35b
Initial plan
Copilot Feb 18, 2026
260c470
Format JSON metadata in AiExtensionTests.cpp for better readability
Copilot Feb 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 44 additions & 4 deletions tests/unit/AiExtensionTests.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,21 @@ TEST_CASE("Model pack loader parses schema and defaults", "[ai]") {

{
std::ofstream meta(tempDir / "model.json");
meta << R"({"schema_version":1,"id":"mix-v1","name":"Mix V1","type":"mix_parameters","engine":"onnxruntime","version":"1.0.0","model_file":"model.onnx","license":"MIT","source":"unit-test","feature_schema_version":"1.0.0","output_schema":{"target_lufs":"float"}})";
meta << R"({
"schema_version": 1,
"id": "mix-v1",
"name": "Mix V1",
"type": "mix_parameters",
"engine": "onnxruntime",
"version": "1.0.0",
"model_file": "model.onnx",
"license": "MIT",
"source": "unit-test",
"feature_schema_version": "1.0.0",
"output_schema": {
"target_lufs": "float"
}
})";
}

const auto pack = loader.load(tempDir);
Expand All @@ -76,13 +90,33 @@ TEST_CASE("Model manager scans packs and stores active selections", "[ai]") {
std::ofstream model(roleDir / "model.onnx", std::ios::binary);
model << "role";
std::ofstream meta(roleDir / "model.json");
meta << R"({"id":"role-classifier-v1","type":"role_classifier","model_file":"model.onnx","license":"MIT","source":"unit-test","feature_schema_version":"1.0.0","output_schema":{"prob_vocals":"float"}})";
meta << R"({
"id": "role-classifier-v1",
"type": "role_classifier",
"model_file": "model.onnx",
"license": "MIT",
"source": "unit-test",
"feature_schema_version": "1.0.0",
"output_schema": {
"prob_vocals": "float"
}
})";
}
{
std::ofstream model(mixDir / "model.onnx", std::ios::binary);
model << "mix";
std::ofstream meta(mixDir / "model.json");
meta << R"({"id":"mix-params-v1","type":"mix_parameters","model_file":"model.onnx","license":"MIT","source":"unit-test","feature_schema_version":"1.0.0","output_schema":{"target_lufs":"float"}})";
meta << R"({
"id": "mix-params-v1",
"type": "mix_parameters",
"model_file": "model.onnx",
"license": "MIT",
"source": "unit-test",
"feature_schema_version": "1.0.0",
"output_schema": {
"target_lufs": "float"
}
})";
}

automix::ai::ModelManager manager(root);
Expand Down Expand Up @@ -114,7 +148,13 @@ TEST_CASE("Model pack loader rejects packs missing licensing metadata", "[ai]")
std::ofstream model(root / "model.onnx", std::ios::binary);
model << "dummy";
std::ofstream meta(root / "model.json");
meta << R"({"id":"invalid-meta-pack","type":"mix_parameters","engine":"onnxruntime","model_file":"model.onnx","feature_schema_version":"1.0.0"})";
meta << R"({
"id": "invalid-meta-pack",
"type": "mix_parameters",
"engine": "onnxruntime",
"model_file": "model.onnx",
"feature_schema_version": "1.0.0"
})";
}

automix::ai::ModelPackLoader loader;
Expand Down