Skip to content

fix: Add notebook forking logic and improve notebook item UI #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
KobenjiSan wants to merge 1 commit into from
Closed

fix: Add notebook forking logic and improve notebook item UI #118

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions ...cts/project-overview/project-overview-view/project-content/project-content.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,22 +1,22 @@
<div class="card">
<div class="d-flex card-header flex-row align-items-center">
<div class="card notebooks-card">
<div class="d-flex card-header flex-row align-items-center notebooks-card__header">
<span class="mr-2">Notebooks</span>
<div class="d-inline-flex ml-auto" *ngIf="!isCurrentDirNotebook">
<!-- Private Button Group Start -->
<div class="btn-group mr-3" role="group" *ngIf="isMember">
<button type="button" class="btn" title="Upload Notebook" (click)="toggleModalUpload()">
<i class="fa fa-plus"></i>
<div class="btn-group notebooks-card__actions" role="group" *ngIf="isMember" aria-label="Notebook creation actions">
<button type="button" class="btn btn-primary" title="Upload Notebook" aria-label="Upload Notebook" (click)="toggleModalUpload()">
<i class="fa fa-plus" aria-hidden="true"></i>
</button>
<button type="button" class="btn" title="Create Folder" (click)="openFolderModal()">
<i class="fa fa-folder-plus"></i>
<button type="button" class="btn btn-outline-primary" title="Create Folder" aria-label="Create Folder" (click)="openFolderModal()">
<i class="fa fa-folder-plus" aria-hidden="true"></i>
</button>
</div>
</div>
</div>
<ul class="list-group">
<li class="list-group-item" *ngIf="currentDirectory.split('/').length>2"
<ul class="list-group notebooks-card__list">
<li class="list-group-item notebooks-card__list-item notebooks-card__nav-up" *ngIf="currentDirectory.split('/').length>2"
(click)="navigateToPreviousComponent()"> . . . </li>
<li class="list-group-item" *ngIf="notebooks.length === 0 && !isCurrentDirNotebook "> No Notebooks Found </li>
<li class="list-group-item notebooks-card__list-item" *ngIf="notebooks.length === 0 && !isCurrentDirNotebook "> No Notebooks Found </li>
<app-project-notebook-item *ngFor="let notebook of notebooks" [project]="project" [notebook]="notebook"
[currentDirectory]="currentDirectory" (navigateToNewDirectory)="navigate($event)"
(getNotebooks)="getNotebooks($event)" (setCurrentNotebook)="displayNotebook($event)"
Expand Down
66 changes: 60 additions & 6 deletions ...cts/project-overview/project-overview-view/project-content/project-content.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,63 @@
.btn {
background-color: var(--button-background-color);
color: var(--primary-color);
.notebooks-card {
border: var(--border-w-1) var(--border-style) var(--border-color);
border-radius: var(--radius-1);
overflow: hidden;
}
.card-header {
background-color: var(--primary-color);

.notebooks-card__header {
background: var(--surface-0);
color: var(--text-on-light);
font-size: var(--fs-18);

padding: var(--space-3) var(--space-4);
border-bottom: var(--border-w-1) var(--border-style) var(--border-color);
}

.notebooks-card__list {
margin: 0;
}

.notebooks-card__list-item {
border-left: 0;
border-right: 0;
}

.notebooks-card__nav-up {
cursor: pointer;
}

.notebooks-card__actions {
display: inline-flex;
align-items: stretch;
}

.notebooks-card__actions .btn {
padding: var(--space-2) var(--space-3) !important;
min-height: 36px;
display: inline-flex;
align-items: center;
justify-content: center;

border-radius: 0 !important;
font-size: var(--fs-16);
line-height: 1;
}

.notebooks-card__actions .btn + .btn {
margin-left: calc(var(--border-w-1) * -1);
}

.notebooks-card__actions .btn:first-child {
border-top-left-radius: var(--radius-1) !important;
border-bottom-left-radius: var(--radius-1) !important;
}

.notebooks-card__actions .btn:last-child {
border-top-right-radius: var(--radius-1) !important;
border-bottom-right-radius: var(--radius-1) !important;
}

.notebooks-card__actions .btn i {
font-size: 18px;
font-weight: 500;
color: currentColor;
}
Loading