Fix npm i by making prepare install devDeps first#19
Closed
tshmieldev wants to merge 1 commit intomainfrom
Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the react-native-pulsar package’s install lifecycle so that running npm install from within PulsarApp no longer fails when the library’s prepare step runs without bob being available.
Changes:
- Updates
react-native-pulsar’spreparescript to run an install step beforebob build.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
Found a possibly better solution: #20 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before, running npm i inside PulsarApp would fail as it ran prepare script in react-native-pulsar which call bob build which was not installed
now, the prepare script runs npm i before running bob