feat: add image.verticalAlign option to htmlStyle#520
Open
fendent wants to merge 1 commit intosoftware-mansion:mainfrom
Open
feat: add image.verticalAlign option to htmlStyle#520fendent wants to merge 1 commit intosoftware-mansion:mainfrom
fendent wants to merge 1 commit intosoftware-mansion:mainfrom
Conversation
Adds an image.verticalAlign property to htmlStyle that controls inline image attachment positioning: - 'baseline' (default): image bottom aligns with the descender - 'bottom': image bottom aligns with the line fragment bottom Implemented for iOS. Adjusts both the layout glyph bounds and the overlay image view position.
Collaborator
|
Hi, thanks so much for the contribution. Could you add screenshots/videos documenting your work? This is helpful for us to better understand introduced changes :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an
image.verticalAlignproperty to thehtmlStyleprop that controls how inline image attachments are vertically positioned within the line.'baseline'(default): existing behavior — image bottom aligns with the font descender'bottom': image bottom aligns with the bottom of the line fragmentThis is useful for chat-style inputs where inline emotes should sit flush with the text baseline rather than floating above it.
Test Plan
htmlStyle— verify image bottom aligns with the descender (existing behavior)htmlStyle={{ image: { verticalAlign: 'bottom' } }}— verify image bottom aligns with the bottom of the line fragmentCompatibility
Checklist