Handle removing exception#2624
Merged
Merged
Conversation
kmagiera
approved these changes
Nov 23, 2021
Member
kmagiera
left a comment
kmagiera
left a comment
There was a problem hiding this comment.
I support this change. I think it does not make sense to catch unchecked exceptions thrown by other libraries in reanimated. Especially that in this particular case the assertion does not really assert against anything and the method could proceed as normal w/o it. I think what would make sense for cases like that is what we discussed offline, that is an ability to disable exiting animations in subtrees
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I am not convinced to fix it by reanimated side. IMO this assertion is not necessary and handling it this way looks like dirty hacks for edge cases. I ask them to remove this assertion. in spite of it, I prepared a fix.
Handle Assert exception during disappearing of a component. Caused by https://github.com/oblador/react-native-shimmer/blob/620a9e899df40e1bef38127d4ef61384e1a195c5/ios/RNShimmeringView.m#L26
Fixes #2554
Related: oblador/react-native-shimmer#33