worklets plugin: Add opt-in bundle mode JSX component capture#9212
Open
hannojg wants to merge 1 commit intosoftware-mansion:mainfrom
Open
worklets plugin: Add opt-in bundle mode JSX component capture#9212hannojg wants to merge 1 commit intosoftware-mansion:mainfrom
hannojg wants to merge 1 commit intosoftware-mansion:mainfrom
Conversation
hannojg
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I am working on something where I am using JSX inside worklets.
Right now we don't capture any JSX functions.
This adds a
bundleModeCaptureJsxComponentsoption to the worklets plugin to capture them if we are in bundle mode.Let me know how you feel about this 😊
Test plan
I added unit tests for this!