fix: improve worklets version resolution and error messages for monor…#9238
Open
elizhabiboullah wants to merge 1 commit intosoftware-mansion:mainfrom
Open
Conversation
…epo setups
In pnpm monorepos, require('react-native-worklets/package.json') may fail
to resolve from Reanimated's install location due to pnpm's strict
dependency isolation. This causes false 'package not installed' errors
even when worklets is correctly installed in the project.
Changes:
- Add fallback resolution using require.resolve with paths:[process.cwd()]
to find worklets from the project root when the standard require fails.
- Improve error messages with monorepo-specific guidance (use overrides/
resolutions to enforce consistent versions across the workspace).
- Both changes are backwards compatible — existing behavior is preserved
as the primary path, with monorepo fallbacks added.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes worklets version resolution in pnpm monorepo setups.
In pnpm monorepos,
require('react-native-worklets/package.json')resolves from Reanimated's own install location rather than the user's project. Due to pnpm's strict dependency isolation, this can fail even when worklets is correctly installed in the project, producing a misleading "package isn't installed" error duringpod install.This PR adds a fallback resolution path using
require.resolvewithpaths: [process.cwd()]and improves error messages with monorepo-specific guidance (e.g., using package manager overrides/resolutions).All changes are backwards compatible, existing resolution is tried first.
Test plan
cd apps/my-app && npx pod-installManual verification: the fix was validated in a real pnpm monorepo where Reanimated 4.3.0 with worklets 0.8.1 was failing to resolve during pod install