feat: OperationsLoop for simpler css animations and transitions updates#9248
Open
feat: OperationsLoop for simpler css animations and transitions updates#9248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds one useful abstraction that moves per-frame animation updates to the separate
OperationsLoopclass and extracts this responsibility fromCSSAnimationsRegistryandCSSTransitionsRegistryclasses.Thanks to this, both classes become simpler and more readable, which will help in the implementation of Core Animation integration in #9236.
This approach will also make it simpler to add different (not time-based) progress providers (different timelines - e.g. scroll-based timeline) as it removes tight coupling of registries with
performOperationsloop. It separates the progress update step from the style calculation, which can now happen independently, thus different progress providers could update animation progress, whilst updates will still be properly collected in the independentperformOperationsloop.