chore(FabricExample, FormSheet v5): Add SFT for stacking FormSheets#4016
Draft
t0maboro wants to merge 1 commit into
Draft
chore(FabricExample, FormSheet v5): Add SFT for stacking FormSheets#4016t0maboro wants to merge 1 commit into
t0maboro wants to merge 1 commit into
Conversation
t0maboro
requested review from
LKuchno,
kkafar,
kligarski,
kmichalikk and
sgaczol
t0maboro
force-pushed
the
@t0maboro/formsheet-modal-v5
branch
from
9eebb45 to
7efa595
Compare
t0maboro
force-pushed
the
@t0maboro/sft-nesting-formsheets
branch
from
68dd2f7 to
a084786
Compare
t0maboro
force-pushed
the
@t0maboro/sft-nesting-formsheets
branch
from
a084786 to
6d9ad79
Compare
kligarski
reviewed
May 18, 2026
Contributor
kligarski
left a comment
kligarski
left a comment
There was a problem hiding this comment.
Simulator.Screen.Recording.-.iPhone.17.Pro.-.2026-05-18.at.17.25.31.mov
What about such situation? Do we need to handle it somehow? Remember that the user can have formsheets as siblings in react tree (the behavior is similar).
LKuchno
reviewed
May 19, 2026
Collaborator
LKuchno
left a comment
LKuchno
left a comment
There was a problem hiding this comment.
The scenario and screen look good, but this is just the base scenario.
As @kligarski noticed - and as discussed during meeting - we should handle dismissing underlying formSheets and cover this behavior in this SFT.
Contributor
Author
|
converting to draft, as this PR needs fixing bugs in the native component's implementation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
SFT verifying that we're able to present one FormSheet on top of another.
Note: I'm not sure whether we should hide a sheet behind the latest presented, or not. For me, its valid that all stacked sheets remain attached, but I'm open for suggestions here.
Closes https://github.com/software-mansion/react-native-screens-labs/issues/1280
Changes
Before & after - visual documentation
ios26.mov