chore(iOS): drop stale React-RCTImage DEFINES_MODULE comment#4037
Open
kkafar wants to merge 1 commit into
Open
Conversation
The lowest supported React Native version is now above 0.81, therefore the fix is already included in all React Native versions we support. It's ok to set 'DEFINES_MODULE' for screens now in user-consumed code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes the long comment above
rnscreens_config['DEFINES_MODULE'] = 'YES'in
RNScreens.podspec. The comment warned that this setting requiredpatching
React-RCTImageto setDEFINES_MODULE, and concluded"we can not have Swift code in stable package."
That justification no longer applies: the upstream
React-RCTImageDEFINES_MODULEfix shipped in React Native 0.81, and this library'sminimum supported RN version is now >= 0.81. Users no longer need
to patch their
react-nativesources, so the comment is misleading.This is split out from #4036 (which flips the gamma default to
opt-out) on purpose: that PR is a behavior change, this one is a
pure comment removal with its own justification.
Changes
RNScreens.podspecabove theDEFINES_MODULEassignment.Test plan
No code change — only a comment removed. Verified locally that
pod installinFabricExample/iosstill succeeds with thedefault (gamma-enabled) configuration.
Checklist