Skip to content

chore(iOS): drop stale React-RCTImage DEFINES_MODULE comment#4037

Open
kkafar wants to merge 1 commit into
@kkafar/set-gamma-enabled-to-true-by-defaultfrom
@kkafar/remove-unnecessary-comment-from-podspec
Open

chore(iOS): drop stale React-RCTImage DEFINES_MODULE comment#4037
kkafar wants to merge 1 commit into
@kkafar/set-gamma-enabled-to-true-by-defaultfrom
@kkafar/remove-unnecessary-comment-from-podspec

Conversation

@kkafar
Copy link
Copy Markdown
Member

@kkafar kkafar commented May 14, 2026

Stacked on top of #4036. Merge that one first.

Description

Removes the long comment above rnscreens_config['DEFINES_MODULE'] = 'YES'
in RNScreens.podspec. The comment warned that this setting required
patching React-RCTImage to set DEFINES_MODULE, and concluded
"we can not have Swift code in stable package."

That justification no longer applies: the upstream React-RCTImage
DEFINES_MODULE fix shipped in React Native 0.81, and this library's
minimum supported RN version is now >= 0.81. Users no longer need
to patch their react-native sources, so the comment is misleading.

This is split out from #4036 (which flips the gamma default to
opt-out) on purpose: that PR is a behavior change, this one is a
pure comment removal with its own justification.

Changes

  • Drop the 6-line comment block in RNScreens.podspec above the
    DEFINES_MODULE assignment.

Test plan

No code change — only a comment removed. Verified locally that
pod install in FabricExample/ios still succeeds with the
default (gamma-enabled) configuration.

Checklist

  • Included code example that can be used to test this change.
  • For visual changes, included screenshots / GIFs / recordings documenting the change.
  • For API changes, updated relevant public types.
  • Ensured that CI passes

The lowest supported React Native version is now above 0.81, therefore
the fix is already included in all React Native versions we support.
It's ok to set 'DEFINES_MODULE' for screens now in user-consumed code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant