refactor(test): Update scenario-description and scenario files for existing tabs tests #4092
Open
LKuchno wants to merge 7 commits into
Open
refactor(test): Update scenario-description and scenario files for existing tabs tests #4092LKuchno wants to merge 7 commits into
LKuchno wants to merge 7 commits into
Conversation
…st, small upateds in scenario e2e section remane from Yes/Other to partial when test is partially automated
LKuchno
added
area:tabs
…ription similar or the same as for values for e2ecoverage
…ns into @lkuchno/scenarioDescription-update
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the test scenario documentation and metadata for the Tabs-related single-feature tests, aligning the scenario.md “E2E test” section and each scenario’s ScenarioDescription.e2eCoverage/smokeTest flags with the newer classification scheme (full / incomplete / tbd) introduced in #4059.
Changes:
- Updated
apps/src/tests/template/scenario.mdto use the new E2E coverage states (Full/Incomplete/Tbd). - Revised multiple Tabs scenarios’
scenario.mdE2E sections to use the new labels and updated wording. - Set correct
e2eCoveragevalues and marked selected Tabs scenarios assmokeTest: trueinscenario-description.ts.
Reviewed changes
Copilot reviewed 25 out of 25 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| apps/src/tests/template/scenario.md | Updates the scenario template E2E section to the new coverage state scheme. |
| apps/src/tests/single-feature-tests/tabs/test-tabs-tab-bar-minimize-behavior-ios/scenario.md | Adjusts E2E coverage wording/label for this scenario. |
| apps/src/tests/single-feature-tests/tabs/test-tabs-tab-bar-minimize-behavior-ios/scenario-description.ts | Sets e2eCoverage to match the scenario’s automation status. |
| apps/src/tests/single-feature-tests/tabs/test-tabs-tab-bar-hidden/scenario.md | Updates E2E coverage label and description text. |
| apps/src/tests/single-feature-tests/tabs/test-tabs-tab-bar-hidden/scenario-description.ts | Sets e2eCoverage to full. |
| apps/src/tests/single-feature-tests/tabs/test-tabs-tab-bar-experimental-user-interface-style-ios/scenario.md | Updates E2E coverage label and explanation. |
| apps/src/tests/single-feature-tests/tabs/test-tabs-tab-bar-experimental-user-interface-style-ios/scenario-description.ts | Sets e2eCoverage to incomplete. |
| apps/src/tests/single-feature-tests/tabs/test-tabs-tab-bar-controller-mode-ios/scenario.md | Updates E2E coverage label to Tbd. |
| apps/src/tests/single-feature-tests/tabs/test-tabs-tab-bar-color-scheme/scenario.md | Updates E2E coverage label and explanation. |
| apps/src/tests/single-feature-tests/tabs/test-tabs-tab-bar-color-scheme/scenario-description.ts | Sets e2eCoverage and marks as smokeTest. |
| apps/src/tests/single-feature-tests/tabs/test-tabs-stale-update-rejection/scenario.md | Updates E2E coverage label and clarifies what’s covered/not covered. |
| apps/src/tests/single-feature-tests/tabs/test-tabs-stale-update-rejection/scenario-description.ts | Sets e2eCoverage and marks as smokeTest. |
| apps/src/tests/single-feature-tests/tabs/test-tabs-special-effects-scroll-to-top/scenario.md | Updates E2E coverage label to Full. |
| apps/src/tests/single-feature-tests/tabs/test-tabs-special-effects-scroll-to-top/scenario-description.ts | Sets e2eCoverage to full. |
| apps/src/tests/single-feature-tests/tabs/test-tabs-simple-nav/scenario-description.ts | Marks as smokeTest. |
| apps/src/tests/single-feature-tests/tabs/test-tabs-prevent-native-selection/scenario.md | Updates E2E coverage label to Incomplete. |
| apps/src/tests/single-feature-tests/tabs/test-tabs-prevent-native-selection/scenario-description.ts | Sets e2eCoverage and marks as smokeTest. |
| apps/src/tests/single-feature-tests/tabs/test-tabs-override-scroll-view-content-inset-ios/scenario.md | Updates E2E coverage label to Full. |
| apps/src/tests/single-feature-tests/tabs/test-tabs-override-scroll-view-content-inset-ios/scenario-description.ts | Sets e2eCoverage to full. |
| apps/src/tests/single-feature-tests/tabs/test-tabs-more-navigation-controller-ios/scenario.md | Updates E2E coverage label to Tbd. |
| apps/src/tests/single-feature-tests/tabs/test-tabs-lifecycle-events/scenario.md | Updates E2E coverage label to Incomplete. |
| apps/src/tests/single-feature-tests/tabs/test-tabs-lifecycle-events/scenario-description.ts | Sets e2eCoverage to incomplete. |
| apps/src/tests/single-feature-tests/tabs/test-tabs-bottom-accessory-layout-ios/scenario.md | Updates E2E coverage label to Incomplete and adjusts wording. |
| apps/src/tests/single-feature-tests/tabs/test-tabs-bottom-accessory-layout-ios/scenario-description.ts | Sets e2eCoverage to incomplete. |
| apps/src/tests/single-feature-tests/tabs/test-tabs-appearance-defined-by-selected-tab/scenario-description.ts | Marks as smokeTest. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ## E2E test | ||
|
|
||
| Yes: Covers all manual scenario steps. For iOS test are covered only for iPhone, e2e is not suitable for iPad execution due to use 'UITabBar' type (on iPad new tab bar at the top is not an instance of UITabBar). | ||
| Full: Covers all manual scenario steps. For iOS test are covered only for iPhone, e2e is not suitable for iPad execution due to use 'UITabBar' type (on iPad new tab bar at the top is not an instance of UITabBar). |
| ## E2E test | ||
|
|
||
| Partial: covers most of manual scenario steps only for iPhone; iPad testing would | ||
| Incomplete: covers most of manual scenario steps only for iPhone; iPad testing would |
| ## E2E test | ||
|
|
||
| Other: E2E test only makes sense on iPad to verify sidebar visibility. Currently, e2e tests are run only on iPhone devices - TBD. | ||
| Tbd: E2E test only makes sense on iPad to verify sidebar visibility. Currently, e2e tests are run only on iPhone devices - TBD. |
LKuchno
changed the title
…under pr4100 about using multiple expected checkboxes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In PR #4059 , we refactored the test directory structure by extracting scenarioDescription into dedicated files. The ScenarioDescription type was extended with two new properties: e2eCoverage and smokeTest, whose values were initially set to tbd and false.
This PR updates the existing files for tabs tests with the correct values taken from the scenarios (E2E section) and marks the tests identified as smokeTest for releases.
The E2E section in several scenarios was also updated. To unify naming for tests coverage we will use values define for e2eCoverage property: fully, incomplete and tbd. For incomplete state, if scenario is not automated at all I started from this information before explanation why it currently can't be covered in e2e.
Scenario.md template updated in e2e section with fully, incomplete and tbd values.
Closes: https://github.com/software-mansion/react-native-screens-labs/issues/1474
Changes