Skip to content

chore(test): add tab-item-icon appearance scenario for iOS#4104

Closed
LKuchno wants to merge 6 commits into
mainfrom
@lkuchno/test-tabs-item-icon-ios
Closed

chore(test): add tab-item-icon appearance scenario for iOS#4104
LKuchno wants to merge 6 commits into
mainfrom
@lkuchno/test-tabs-item-icon-ios

Conversation

@LKuchno
Copy link
Copy Markdown
Collaborator

@LKuchno LKuchno commented May 27, 2026

Description

Adds a new manual test scenario (test-tabs-item-icon-ios) that exercises the iOS tab bar item icon color props exposed on TabsScreen. The scenario covers four distinct icon configuration cases: templateSource (tintable, check with host tint), sfSymbol with tabBarItemIconColor override, xcasset (tintable, check with host tint), and imageSource (non-tintable). It verifies that standardAppearance.stacked.selected.tabBarItemIconColor correctly overrides the host-level tabBarTintColor for the selected icon color, and that imageSource icons are non-tintable and unaffected by either prop.

This is iOS-only. Automated Detox assertions are not feasible because Detox does not expose tint color or rendered image attributes of native tab bar items. Known behavioral differences between iOS 18 and iOS 26 are documented in the scenario notes.

Closes: https://github.com/software-mansion/react-native-screens-labs/issues/1399

Changes

  • Tests/Tabs: Added test-tabs-item-icon-ios/index.tsx - new test screen with four tab routes exercising templateSource host-tint, sfSymbol with tabBarItemIconColor override, xcasset host-tint, and non-tintable imageSource icon
  • Tests/Tabs: Added scenario-description.ts registering the scenario as iOS-only, e2eCoverage: 'incomplete', smokeTest: false
  • Tests/Tabs: Added scenario.md with full manual test steps, iOS 18 vs iOS 26 known-issue callouts, and per-step verification checklists
  • Tests/Tabs: Registered TestTabsItemIcon in apps/src/tests/single-feature-tests/tabs/index.ts

@LKuchno LKuchno added platform:ios Issue related to iOS part of the library area:tabs Issue related to bottom tabs type:chore A general maintenance task, that does not fall into other categories. labels May 27, 2026
@LKuchno LKuchno requested a review from Copilot May 27, 2026 09:50
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an iOS-only manual test scenario for validating tab bar item icon appearance behavior across different TabsScreen icon sources and tint/override configurations.

Changes:

  • Adds a new test-tabs-item-icon-ios scenario implementation and metadata.
  • Documents manual verification steps for tintable and non-tintable icon cases.
  • Registers the scenario in the Tabs single-feature test group.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
apps/src/tests/single-feature-tests/tabs/test-tabs-item-icon-ios/index.tsx Implements the four-tab manual scenario and icon configurations.
apps/src/tests/single-feature-tests/tabs/test-tabs-item-icon-ios/scenario-description.ts Defines scenario metadata and iOS-only coverage status.
apps/src/tests/single-feature-tests/tabs/test-tabs-item-icon-ios/scenario.md Adds manual test instructions and expected results.
apps/src/tests/single-feature-tests/tabs/index.ts Registers the new scenario in the Tabs group.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread apps/src/tests/single-feature-tests/tabs/test-tabs-item-icon-ios/scenario.md Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@LKuchno LKuchno requested review from kkafar and removed request for kkafar May 27, 2026 11:01
@LKuchno
Copy link
Copy Markdown
Collaborator Author

LKuchno commented May 29, 2026

PR closed as new screen for both platforms were implemented and introduced in #4108

@LKuchno LKuchno closed this May 29, 2026
@LKuchno LKuchno reopened this May 29, 2026
@LKuchno LKuchno closed this May 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:tabs Issue related to bottom tabs platform:ios Issue related to iOS part of the library type:chore A general maintenance task, that does not fall into other categories.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants