chore(test): add tab-item-icon appearance scenario for iOS#4104
Closed
LKuchno wants to merge 6 commits into
Closed
chore(test): add tab-item-icon appearance scenario for iOS#4104LKuchno wants to merge 6 commits into
LKuchno wants to merge 6 commits into
Conversation
…ns into @lkuchno/test-tabs-item-icon-ios
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an iOS-only manual test scenario for validating tab bar item icon appearance behavior across different TabsScreen icon sources and tint/override configurations.
Changes:
- Adds a new
test-tabs-item-icon-iosscenario implementation and metadata. - Documents manual verification steps for tintable and non-tintable icon cases.
- Registers the scenario in the Tabs single-feature test group.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
apps/src/tests/single-feature-tests/tabs/test-tabs-item-icon-ios/index.tsx |
Implements the four-tab manual scenario and icon configurations. |
apps/src/tests/single-feature-tests/tabs/test-tabs-item-icon-ios/scenario-description.ts |
Defines scenario metadata and iOS-only coverage status. |
apps/src/tests/single-feature-tests/tabs/test-tabs-item-icon-ios/scenario.md |
Adds manual test instructions and expected results. |
apps/src/tests/single-feature-tests/tabs/index.ts |
Registers the new scenario in the Tabs group. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Collaborator
Author
|
PR closed as new screen for both platforms were implemented and introduced in #4108 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a new manual test scenario (
test-tabs-item-icon-ios) that exercises the iOS tab bar item icon color props exposed onTabsScreen. The scenario covers four distinct icon configuration cases:templateSource(tintable, check with host tint),sfSymbolwithtabBarItemIconColoroverride,xcasset(tintable, check with host tint), andimageSource(non-tintable). It verifies thatstandardAppearance.stacked.selected.tabBarItemIconColorcorrectly overrides the host-leveltabBarTintColorfor the selected icon color, and thatimageSourceicons are non-tintable and unaffected by either prop.This is iOS-only. Automated Detox assertions are not feasible because Detox does not expose tint color or rendered image attributes of native tab bar items. Known behavioral differences between iOS 18 and iOS 26 are documented in the scenario notes.
Closes: https://github.com/software-mansion/react-native-screens-labs/issues/1399
Changes
test-tabs-item-icon-ios/index.tsx- new test screen with four tab routes exercisingtemplateSourcehost-tint,sfSymbolwithtabBarItemIconColoroverride,xcassethost-tint, and non-tintableimageSourceiconscenario-description.tsregistering the scenario as iOS-only,e2eCoverage: 'incomplete',smokeTest: falsescenario.mdwith full manual test steps, iOS 18 vs iOS 26 known-issue callouts, and per-step verification checklistsTestTabsItemIconinapps/src/tests/single-feature-tests/tabs/index.ts