chore(test): test-tabs-item-title appearance sceanrio#4106
Open
LKuchno wants to merge 3 commits into
Open
Conversation
…enario with configuration for Android and scenario steps for it
…s, remoce green color set for Font tab on android
LKuchno
added
platform:ios
Contributor
There was a problem hiding this comment.
Pull request overview
This PR replaces the iOS-only tab bar item title scenario with a unified iOS/Android manual test scenario for validating tab title rendering, state colors, typography, sizing, and iOS position adjustment.
Changes:
- Adds a new
test-tabs-item-titlescenario covering both platforms. - Registers the unified scenario instead of the iOS-suffixed one.
- Removes the old
test-tabs-item-title-iosscenario files.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
apps/src/tests/single-feature-tests/tabs/test-tabs-item-title/scenario.md |
Adds the unified manual test scenario documentation. |
apps/src/tests/single-feature-tests/tabs/test-tabs-item-title/scenario-description.ts |
Defines the new cross-platform scenario metadata. |
apps/src/tests/single-feature-tests/tabs/test-tabs-item-title/index.tsx |
Implements the new cross-platform tab title test screen. |
apps/src/tests/single-feature-tests/tabs/test-tabs-item-title-ios/scenario.md |
Removes the old iOS-only scenario documentation. |
apps/src/tests/single-feature-tests/tabs/test-tabs-item-title-ios/scenario-description.ts |
Removes old iOS-only scenario metadata. |
apps/src/tests/single-feature-tests/tabs/test-tabs-item-title-ios/index.tsx |
Removes the old iOS-only test screen. |
apps/src/tests/single-feature-tests/tabs/index.ts |
Updates scenario registration to the unified directory. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -0,0 +1,111 @@ | |||
| # Test Scenario: Tab Bar Item Title (iOS) | |||
| ## Details | ||
|
|
||
| Validates the tab bar item title configuration across both platforms, verifying | ||
| the core options.title rendering alongside long-string truncation.It checks |
Comment on lines
+94
to
+97
| (San Francisco, non-italic, 10 pt). | ||
| The title label is shifted noticeably upward (by ~6 points) compared to | ||
| the baseline position seen on the **Color** tab, while the icon position remains | ||
| unchanged. |
LKuchno
changed the title
…heckbox to make it more clear
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
test-tabs-item-title-iosscreen and scenario (added in chore(tabs): add tab-item-title appearance scenario for iOS #4083) with a unifiedtest-tabs-item-titlethat covers both iOS and Android tab bar item title props in a single file.Platform.OSto render platform-appropriate explanatory text; eachTabRouteConfignow carries bothiosandandroidblocks covering font color (selected/normal/focused states), font family, font size (iOS: single size with position adjustment; Android: small/large label sizes), font style, and font weight.apps/src/tests/single-feature-tests/tabs/index.tsto point to the new unified directory, removing the platform-suffixed import.Closes: https://github.com/software-mansion/react-native-screens-labs/issues/1403
Changes:
Test screen record:
Screen.Recording.2026-05-28.at.12.08.05.mov