feat(ios): add subtitle support for UIMenu header button submenus#4107
Open
andreavrr wants to merge 1 commit into
Open
feat(ios): add subtitle support for UIMenu header button submenus#4107andreavrr wants to merge 1 commit into
andreavrr wants to merge 1 commit into
Conversation
UIMenuElement.subtitle is a writable property available since iOS 15. This patch reads the 'subtitle' key from the menu item dictionary and assigns it after UIMenu creation, mirroring the existing subtitle support already present for UIAction items. Closes: adds subtitle to HeaderBarButtonItemSubmenu TypeScript type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
UIMenuElement.subtitleis a writable property available since iOS 15. This adds support for setting a subtitle onUIMenu(submenus) in header bar button items, mirroring the existing subtitle support already present forUIActionitems (added in #3396).The approach is straightforward: after creating the
UIMenuvia the existing initializer, we assignmenu.subtitleif thesubtitlekey is present in the config dictionary.TypeScript: adds
subtitle?: stringtoHeaderBarButtonItemSubmenu.Use case
Showing the currently selected filter value below a submenu label — the same pattern used in Apple's own apps (e.g. Photos).
Changes
ios/RNSBarButtonItem.mm— assignsubtitleonUIMenuafter creation (iOS 15+)src/types.tsx— addsubtitle?: string | undefinedtoHeaderBarButtonItemSubmenuChecklist