refactor(test): update test-tabs-ime-insets name and create scenario for it#4109
Merged
Conversation
LKuchno
added
platform:android
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Tabs “IME insets” single-feature test to be explicitly Android-only by renaming the scenario directory/key and adding a manual scenario.md describing verification steps for tabBarRespectsIMEInsets and bottom safe-area behavior.
Changes:
- Renamed the scenario to
test-tabs-ime-insets-androidand updated thescenarioDescription.keyaccordingly. - Added a new manual test scenario document (
scenario.md) with step-by-step expectations. - Updated the tabs scenario group import to point to the renamed scenario path.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| apps/src/tests/single-feature-tests/tabs/test-tabs-ime-insets-android/scenario.md | Adds manual test instructions for IME/tab bar/safe-area behavior. |
| apps/src/tests/single-feature-tests/tabs/test-tabs-ime-insets-android/scenario-description.ts | Updates the scenario key to the new Android-specific identifier. |
| apps/src/tests/single-feature-tests/tabs/test-tabs-ime-insets-android/index.tsx | Defines the scenario UI for toggling safe-area bottom edge and tabBarRespectsIMEInsets. |
| apps/src/tests/single-feature-tests/tabs/index.ts | Updates the scenario import path to the renamed Android-only scenario. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
kligarski
approved these changes
Jun 1, 2026
…- leaving just dismiss action
…ansion/react-native-screens into @lkuchno/test-tabs-IME-insets
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Existing test-tabs-ime-insets screen was updated with new scenario.md file, directory name and key was updated with platform name as this test is Android only.
Closes: https://github.com/software-mansion/react-native-screens-labs/issues/1405
Changes
test-tabs-ime-insetsdirectory renamed to test-tabs-ime-insets-androidscenario-description.ts: key set to test-tabs-ime-insets-androidscenario.mdwas created with manual scenario stepsindex.tsxfile was updated with new path to screen