chore: remove Paper and unsupported RN versions leftovers#4110
Open
sgaczol wants to merge 7 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes leftover code paths for the legacy Paper architecture and for unsupported older React Native versions (now targeting RN >= 0.82), simplifying platform/version conditionals across JS/TS, iOS native, and Android build configuration.
Changes:
- Simplifies iOS Tabs bottom accessory rendering by removing RN-version branching and always using the dual-render approach when available.
- Removes Paper-only SearchBar prop normalization and other RN-version-specific conditionals.
- Cleans up native iOS includes and Android Gradle packaging/dependency workarounds that were only needed for older RN versions.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/components/tabs/host/TabsHost.ios.types.ts | Updates docs to remove legacy/Paper and RN<0.82 behavioral notes for bottom accessory. |
| src/components/tabs/host/TabsHost.ios.tsx | Removes RN-version branching and legacy environment-change state for bottom accessory rendering. |
| src/components/SearchBar.tsx | Removes Paper-only prop parsing for autoCapitalize. |
| src/components/ScreenStackItem.tsx | Drops RN minor version gating for a formSheet positioning path (now relying on feature flag only). |
| ios/tabs/bottom-accessory/RNSTabsBottomAccessoryHelper.mm | Removes unused React Native version header include. |
| ios/tabs/bottom-accessory/RNSTabsBottomAccessoryContentComponentView.h | Removes unused React Native version header include (but leaves an empty preprocessor block). |
| ios/safe-area/RNSSafeAreaViewComponentView.mm | Removes unused React Native version header include. |
| ios/RNSScreenStackHeaderSubview.mm | Removes unused React Native version header include. |
| ios/RNSScreenStackHeaderConfig.mm | Removes unused React Native version header include. |
| ios/RNSScreen.mm | Removes unused React Native version header include. |
| ios/gamma/split/RNSSplitScreenShadowStateProxy.mm | Removes unused React Native version header include. |
| ios/conversion/RNSConversions-Tabs.mm | Removes unused React Native version header include. |
| android/build.gradle | Updates packaging excludes and removes a dependency constraint that was only needed for older RN versions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
7
to
9
| #if defined(__cplusplus) | ||
|
|
||
| #import <cxxreact/ReactNativeVersion.h> | ||
|
|
||
| #endif // defined(__cplusplus) |
Removed unnecessary C++ preprocessor directives.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes leftovers of Paper or not supported anymore React Native versions - related code.
For
android/build.gradlethis means:libreact_render*.so,libreactnativejni.soandlibreact_performance_timeline.sowere dropped frompackagingOptions.excludes— these libraries were merged intolibreactnative.soin RN 0.76.lifecycle-viewmodel-ktx:2.5.1constraints block was removed — it fixed a duplicate-class conflict (androidx.lifecycle.ViewModelLazy) on older RN versionsChanges
SearchBar.tsx: removed the Paper-onlyparseUndefinedPropsToSystemDefaultwhich madeautoCapitalize'systemDefault'if undefinedandroid/build.gradle: modified accordingly to the description above#import <cxxreact/ReactNativeVersion.h>removed from several filesScreenStackItem.tsx,TabsHost.ios.tsx: removed conditions related to RN < 0.82TabsHost.ios.types.ts: updated a commentBefore & after - visual documentation
N/A
Test plan
Build example apps.
Checklist