fix(ios): weak-capture tab bar item and screen view in async image callbacks#4111
Draft
cortinico wants to merge 1 commit into
Draft
fix(ios): weak-capture tab bar item and screen view in async image callbacks#4111cortinico wants to merge 1 commit into
cortinico wants to merge 1 commit into
Conversation
…llbacks Avoid updating a tab bar item whose internal view hierarchy has been torn down. This works around an iOS 26 UIKit regression where unowned refs inside UITabBarItem._updateViewAndPositionItems: cause crashes. Both the normal icon and selected icon completion blocks now: 1. Weak-capture tabBarItem and screenView before the block 2. Promote to strong refs inside the block and bail if either is nil 3. Guard that the screen's controller is still parented by a UITabBarController
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Avoid updating a tab bar item whose internal view hierarchy has been
torn down. This works around an iOS 26 UIKit regression where unowned
refs inside UITabBarItem._updateViewAndPositionItems: cause crashes.
Both the normal icon and selected icon completion blocks now:
Before & after - visual documentation
TBA
Test plan
Discussed offline
Checklist