Skip to content

Split up authToken unit test for readability#50

Open
hkamm123 wants to merge 2 commits intosoftwareconstruction240:mainfrom
hkamm123:main
Open

Split up authToken unit test for readability#50
hkamm123 wants to merge 2 commits intosoftwareconstruction240:mainfrom
hkamm123:main

Conversation

@hkamm123
Copy link
Copy Markdown

This PR makes two contributions:

  1. splits up a unit test ("Unique authToken each login") into two: one that tests authToken uniqueness across multiple logins, and another that tests individual authToken validity across multiple logins/logouts (the previous version of the test was testing this, but did not declare so).
  2. updates the order of the tests.

Copy link
Copy Markdown
Contributor

@mewilker mewilker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was worried this would miss an edge case, but now that I look at it closer I see that it shouldn't! Something we could do that could potentially help readablility is make a function for the double login, but I don't think that's completely necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants