Open
Conversation
I added the ability to submit an object that can take a WebRequest as an argument and then configure it. This is what I build the Thali logic on top of. I don't love this design but it will do for the moment. Changed to latest json.net via nuget, bug fix & .gitignore Nuget - All the cool kids use it, so I set up the project to use nuget to get the latest version of json.net .gitignore - Updated to ignore packages downloaded by nuget empty responses - In the case of certain kinds of errors the server's response might not have a response body which causes an exception because GetJObject requires a response body to exist. Fixed this by adding a constructor in CouchResponseObject that takes no arguments and teaching CouchResponse to use that constructor if the response body has no value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is really meant to start a conversation. I'll send a separate email with details.
I added the ability to submit an object that can take a WebRequest as
an argument and then configure it. This is what I build the Thali
logic on top of. I don't love this design but it will do for the moment.
Changed to latest json.net via nuget, bug fix & .gitignore
Nuget - All the cool kids use it, so I set up the project to use nuget to
get the latest version of json.net
.gitignore - Updated to ignore packages downloaded by nuget
empty responses - In the case of certain kinds of errors the server's
response might not have a response body which causes an exception because
GetJObject requires a response body to exist. Fixed this by adding
a constructor in CouchResponseObject that takes no arguments and
teaching CouchResponse to use that constructor if the response body
has no value.