Enables bulk document save and user creation on a Cluster#71
Open
nfbvieira wants to merge 1 commit intosoitgoes:masterfrom
Open
Enables bulk document save and user creation on a Cluster#71nfbvieira wants to merge 1 commit intosoitgoes:masterfrom
nfbvieira wants to merge 1 commit intosoitgoes:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While the
/db/_bulk_docsAPI documentation refers that:when working with a clustered environment the actual status code returned is
202 Accepted, which causes an exception to be thrown inCouchDatabaseclass when validating the response of the bulk docs insertion atSaveDocumentsmethod:if (resp.StatusCode != HttpStatusCode.Created) {throw new System.Exception("Response returned with a HTTP status code of " + resp.StatusCode + " - " + resp.StatusDescription);}A similar validation is made at
CouchClientclass, when creating a user atCreateUsermethod.The CouchDB documentation regarding this behavior is unclear, and the only mentions I've found to the return of this status code were at
/dband/db/docAPI documentation, stating that it is returned when the data was accepted but not yet stored to disk.I´ve added the
Acceptedstatus code to both validations mentioned above.