Skip to content

fix(ci): use only implemented builder methods in generate-ts-client#25

Merged
dev-jodee merged 1 commit intomainfrom
fix/ci-generate-ts-client-builder-chain
Mar 16, 2026
Merged

fix(ci): use only implemented builder methods in generate-ts-client#25
dev-jodee merged 1 commit intomainfrom
fix/ci-generate-ts-client-builder-chain

Conversation

@dev-jodee
Copy link
Collaborator

Summary

  • scripts/generate-ts-client.ts was calling .appendAccountDiscriminator(), .appendPdaDerivers(), .setInstructionAccountDefaultValues(), .updateInstructionBumps(), and .removeEmitInstruction() on EscrowCodamaBuilder — none of which exist
  • This caused the prebuild step to crash, leaving the generated TypeScript client absent, which then caused all downstream steps (lint, typecheck, build) to fail
  • Fix: use only the two implemented methods — .appendAccountVersion().build() — matching generate-clients.ts

Test plan

  • pnpm --filter @solana/escrow-program-web prebuild succeeds
  • pnpm eslint apps/web passes (no unresolved type errors)
  • Web CI passes

The script was calling .appendAccountDiscriminator(), .appendPdaDerivers(),
.setInstructionAccountDefaultValues(), .updateInstructionBumps(), and
.removeEmitInstruction() which were never implemented on EscrowCodamaBuilder.
Use only .appendAccountVersion().build(), matching generate-clients.ts.
@dev-jodee dev-jodee merged commit e1bfb61 into main Mar 16, 2026
6 checks passed
@dev-jodee dev-jodee deleted the fix/ci-generate-ts-client-builder-chain branch March 16, 2026 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants