[program, secp256k1-verify] Add secp256k1-verify library#6
Merged
Conversation
zz-sol
reviewed
Jun 29, 2026
zz-sol
left a comment
zz-sol
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. Thanks.
Can you please also update the make file so that CI covers unit tests for the new crate? currently it checks program only
|
|
||
| [dependencies] | ||
| solana-secp256k1-recover = { workspace = true } | ||
| solana-keccak-hasher = { workspace = true, optional = true } |
Collaborator
There was a problem hiding this comment.
seems like keccak cannot be optional
cargo check -p solana-secp256k1-verify --no-default-features --features sha256
failed for me.
Also it seems that all the use cases (such as evm address) requires keccak so it makes sense to make it non-optional.
Contributor
Author
There was a problem hiding this comment.
Okay yeah the problem was that the feature scoping was incomplete. I made the library explicitly support non-EVM verification, which technically doesn't require keccak, so I don't think we should make keccak mandatory. I updated the code, so let me know how it looks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I refactored out the verification logic in the current program into a separate library so that other projects and choose to verify signatures inside their own programs without invoking our secp256k1 program.
I tried to design the verifier API to be flexible so that developers can choose the configuration they want out of the box. See the README.md for examples.
I noticed a couple of room for improvements, which I created github issues for.