-
Notifications
You must be signed in to change notification settings - Fork 4
fix: prettier 설정 통일 및 포맷팅 수정 #357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@khwww is attempting to deploy a commit to the solid-connection Team on Vercel. A member of the Team first needs to authorize it. |
Walkthrough이 변경사항은 세 개의 파일에 걸쳐 포매팅 및 설정 조정을 포함합니다.
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~4 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @.vscode/settings.json:
- Line 2: You added "prettier.requireConfig": true to .vscode/settings.json but
the repo lacks a .prettierrc.json; create a .prettierrc.json at the repository
root and populate it with the required Prettier settings (e.g., tabWidth/indent,
semi, singleQuote, printWidth, trailingComma) so Prettier runs locally when
"prettier.requireConfig" is enabled; ensure the new file reflects your project's
conventions and is committed to the repo.
manNomi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다!
/)__/)
( • 0 • ) 🥕
^^
| @@ -1,5 +1,5 @@ | |||
| { | |||
| "prettier.printWidth": 100, | |||
| "prettier.requireConfig": true, | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
혹시 이값 true로 수정하신 이유가 있을까요 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
개인의 전역 설정이 prettier에 적용되는 경우를 방지하기 위해서
.prettier.json 설정을 기준으로 일관되게 포맷되도록 했습니다!
(저게 충돌원인은 아닌 것 같아요)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오 좋네요~!!
아마 프리티어.json이 있어서 해당 옵션이 쓰일일은 없겠지만 명시적으로 개인설정이 적용되는걸 막으면 좋겠네요
작업 내용
.vscode/settings.json에서prettier.printWidth: 100제거prettier.requireConfig: true추가하여.prettierrc.json설정만 따르도록 설정리뷰 요구사항 (선택)
Prettier 설정 통일 방식에 대해 더 좋은 방법이 있다면 이야기 나눠봐도 좋을 것 같아요!