Fix: stop writing foaf:knows when sharing a resource#65
Open
PreciousOritsedere wants to merge 1 commit into
Open
Fix: stop writing foaf:knows when sharing a resource#65PreciousOritsedere wants to merge 1 commit into
PreciousOritsedere wants to merge 1 commit into
Conversation
PreciousOritsedere
requested review from
hkir-dev,
jeswr,
langsamu and
matthieubosquet
as code owners
July 23, 2026 13:38
jeswr
reviewed
Jul 24, 2026
| throw error; | ||
| } | ||
| } | ||
| } No newline at end of file |
Contributor
There was a problem hiding this comment.
Please make sure there is an EOF character here - and open an issue to set up eslint so that we have linting rules stopping this from happening in the future.
jeswr
requested changes
Jul 24, 2026
jeswr
left a comment
jeswr
left a comment
Contributor
There was a problem hiding this comment.
We should still keep track of who we have shared resources with so that they turn up as "quick search" options.
This data should be maintained as a set of contacts in a private resource linked to from the preference file of the user sharing the resource.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #56 and closes #47