Skip to content

feat: vite preview#2060

Merged
brenelz merged 10 commits into
solidjs:mainfrom
huseeiin:vite-preview
Feb 8, 2026
Merged

feat: vite preview#2060
brenelz merged 10 commits into
solidjs:mainfrom
huseeiin:vite-preview

Conversation

@huseeiin

Copy link
Copy Markdown
Contributor

add vite preview support 🎉

@changeset-bot

changeset-bot Bot commented Jan 29, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 5f651e0

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify

netlify Bot commented Jan 29, 2026

Copy link
Copy Markdown

Deploy Preview for solid-start-landing-page ready!

Name Link
🔨 Latest commit 5f651e0
🔍 Latest deploy log https://app.netlify.com/projects/solid-start-landing-page/deploys/6987d38c9c960f00083daf6e
😎 Deploy Preview https://deploy-preview-2060--solid-start-landing-page.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@pkg-pr-new

pkg-pr-new Bot commented Jan 29, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/solidjs/solid-start/@solidjs/start@2060
npm i https://pkg.pr.new/solidjs/solid-start/@solidjs/vite-plugin-nitro-2@2060

commit: 5f651e0

@huseeiin huseeiin marked this pull request as draft January 29, 2026 13:47
@huseeiin huseeiin marked this pull request as ready for review January 29, 2026 13:52
@huseeiin huseeiin marked this pull request as draft January 29, 2026 14:03
@huseeiin huseeiin marked this pull request as ready for review January 29, 2026 14:11
@brenelz

brenelz commented Feb 4, 2026

Copy link
Copy Markdown
Contributor

Why are all our checks failing on this pr?

Comment thread packages/start/src/config/dev-server.ts
@huseeiin

huseeiin commented Feb 4, 2026

Copy link
Copy Markdown
Contributor Author

Why are all our checks failing on this pr?

because i did globalThis.CAN_SEND_FAST_NODE_STREAMS = true which is a type that doesn't exist, but i learned its not needed.

@brenelz

brenelz commented Feb 8, 2026

Copy link
Copy Markdown
Contributor

@lxsmnsyc Does this seem reasonable. Pretty small change overall

@brenelz brenelz merged commit a9cd2cc into solidjs:main Feb 8, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants