Skip to content

improve performance#2063

Closed
huseeiin wants to merge 11 commits into
solidjs:mainfrom
huseeiin:improve-performance
Closed

improve performance#2063
huseeiin wants to merge 11 commits into
solidjs:mainfrom
huseeiin:improve-performance

Conversation

@huseeiin

@huseeiin huseeiin commented Feb 3, 2026

Copy link
Copy Markdown
Contributor

improve performance by ~38% by:

  1. not creating new URLs
  2. sending node streams in supporting environments

PR Checklist

Please check if your PR fulfills the following requirements:

  • Addresses an existing open issue: fixes #000
  • Tests for the changes have been added (for bug fixes / features)

What is the current behavior?

What is the new behavior?

Other information

@changeset-bot

changeset-bot Bot commented Feb 3, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: c30dc29

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify

netlify Bot commented Feb 3, 2026

Copy link
Copy Markdown

Deploy Preview for solid-start-landing-page ready!

Name Link
🔨 Latest commit c30dc29
🔍 Latest deploy log https://app.netlify.com/projects/solid-start-landing-page/deploys/69844886f78a94000881c863
😎 Deploy Preview https://deploy-preview-2063--solid-start-landing-page.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@pkg-pr-new

pkg-pr-new Bot commented Feb 3, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/solidjs/solid-start/@solidjs/start@2063
npm i https://pkg.pr.new/solidjs/solid-start/@solidjs/vite-plugin-nitro-2@2063

commit: c30dc29

Comment thread packages/start/src/server/handler.ts Outdated
@huseeiin huseeiin marked this pull request as draft February 3, 2026 14:58
@huseeiin huseeiin marked this pull request as ready for review February 3, 2026 15:48
@huseeiin huseeiin marked this pull request as draft February 3, 2026 18:38
@huseeiin huseeiin marked this pull request as ready for review February 4, 2026 12:53
@brenelz

brenelz commented Feb 7, 2026

Copy link
Copy Markdown
Contributor

@Brendonovich does this seem reasonable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants