Add TaxonRevenue condition#6492
Open
mamhoff wants to merge 2 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6492 +/- ##
=======================================
Coverage 89.68% 89.68%
=======================================
Files 992 993 +1
Lines 20845 20863 +18
=======================================
+ Hits 18694 18712 +18
Misses 2151 2151 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
72589ee to
2c05beb
Compare
This condition adds a promotion condition that allows store owners to trigger a benefit if the revenue from a defined set of taxons exceeds some value. For example, with this condition we can do things like: If you spend 150 USD on pants, you get a free belt.
This fixes an edge case, a taxon condition without any taxons defined. Prior to this commit, that would error on MySQL and Postgres.
jarednorman
approved these changes
Jun 3, 2026
adammathys
approved these changes
Jun 3, 2026
AlistairNorman
approved these changes
Jun 3, 2026
Contributor
AlistairNorman
left a comment
There was a problem hiding this comment.
Nice, seems like a useful condition to have!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This condition adds a promotion condition that allows store owners to trigger a benefit if the revenue from a defined set of taxons exceeds some value. For example, with this condition we can do things like: If you spend 150 USD on pants, you get a free belt.
Checklist
The following are not always needed: