fix: resolve CI failures on develop branch#658
Open
solofberlin wants to merge 1 commit into
Open
Conversation
- Vendor telegex 1.8.0 with plug declared as a proper dependency to fix compilation failure on Elixir 1.19/OTP 28 (telegex hex package declares plug as optional+dev-only, causing Plug.Router to be unavailable during dep compilation due to strict isolation) - Add catch-all handle_info clause in Coder for stale port messages that arrive after the port has been closed/reset - Restore failed->state-change notification so parent agents receive both the state transition and error detail messages - Fix formatting issues in tool_dispatch, signal, and test files Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
plugdeclared as a proper dependency — the hex package declares plug asoptional: true, only: [:dev, :test], which gets stripped during publishing. On Elixir 1.19/OTP 28's stricter dep compilation isolation, this causesPlug.Routerto be unavailable during telegex compilation, breakingmix compilehandle_infoclause inCoderfor stale port messages that arrive after the port has been closed/reset (preventsFunctionClauseErrorcrash):failedstate-change notification so parent agents receive both the state transition message and the error detail messagetool_dispatch.ex,signal.ex, and test files to passmix format --check-formattedTest plan
mix compilesucceeds from clean_buildmix format --check-formattedpassesmix testpasses (2099 tests, 0 failures; pre-existing flaky history test passes on retry viamix test --failed)CoderNotificationsTestspecifically passes🤖 Generated with Claude Code