Replace slash commands with make targets, convert reviewers to skills#776
Merged
Conversation
- Inline the canonical `make build/test/lint` invocations into `CLAUDE.md` and
delete `.claude/commands/{build,pytest,gtest,lint,format}.md`.
- Move `.claude/agents/{cpp,python}-style-review.md` to
`.claude/skills/<name>/SKILL.md` so the rules apply in the caller's context.
- Mark `make format` / `make pyformat` as work-in-progress in `CLAUDE.md` and
the Makefile, and drop them from `.claude/settings.json` allowlist.
- Update `CLAUDE.md` and `contrib/prompt/general-rule.md` to reference skills
(not subagents) and the surviving make targets.
Related to solvcon#773 and solvcon#774.
yungyuc
added
refactor
yungyuc
commented
May 13, 2026
| findings (include ordering, angle brackets) and other non-auto-fixable | ||
| nits, try to hand-fix. | ||
|
|
||
| Do not run `make pyformat` or `make format`. They are still work in progress. |
Member
Author
There was a problem hiding this comment.
make format depends on make pyformat, which is still work in progress. See issue #775 .
| not hand-fix yourself. | ||
| - Try to hand-fix formatting nits. `make flake8` verifies but does not fix. | ||
|
|
||
| Do not run `make pyformat`, which is not set up to conform to the existing |
Member
Author
There was a problem hiding this comment.
make pyformat is still work in progress. See issue #775 .
| Claude for: routing, retries, deterministic transforms. If code can answer, | ||
| code answers. In this repo, hooks under `.claude/hooks/` own the deterministic | ||
| checks (ASCII, trailing whitespace, modeline, line length); subagents own the | ||
| checks (ASCII, trailing whitespace, modeline, line length); skills own the |
| `contrib/prompt/general-rule.md` (not auto-imported). This section indexes | ||
| the tools. | ||
|
|
||
| ### Slash commands (`.claude/commands/`) |
Member
Author
There was a problem hiding this comment.
Slash commands are all about run tests and incorporated right in this file CLAUDE.md. This is for issue #773 .
Member
Author
There was a problem hiding this comment.
Changing sub agents to skills. This is for issue #774 .
| .PHONY: lint | ||
| lint: cformat cinclude flake8 checkascii checktws | ||
|
|
||
| # FIXME: Do not run pyformat. It is not yet configured to conform to the style |
Member
Author
|
@iefiru FYI. |
This was referenced May 13, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make build/test/lintinvocations intoCLAUDE.mdand delete.claude/commands/{build,pytest,gtest,lint,format}.md..claude/agents/{cpp,python}-style-review.mdto.claude/skills/<name>/SKILL.mdso the rules apply in the caller's context.make format/make pyformatas work-in-progress inCLAUDE.mdand the Makefile, and drop them from.claude/settings.jsonallowlist.CLAUDE.mdandcontrib/prompt/general-rule.mdto reference skills (not subagents) and the surviving make targets.Related to #773 and #774.