lldp-syncd: handle unsupported LLDP port and chassis subtypes#78
Open
KeshavSM10 wants to merge 4 commits intosonic-net:masterfrom
Open
lldp-syncd: handle unsupported LLDP port and chassis subtypes#78KeshavSM10 wants to merge 4 commits intosonic-net:masterfrom
KeshavSM10 wants to merge 4 commits intosonic-net:masterfrom
Conversation
|
|
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: unknown <harshavardhanmundada@gmail.com> Signed-off-by: KeshavSM10 <harshavardhanmundada@gmail.com>
Signed-off-by: KeshavSM10 <harshavardhanmundada@gmail.com>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: KeshavSM10 <harshavardhanmundada@gmail.com>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Author
|
Hey, could someone please review this PR? It has been open since December and addresses issue #24902. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: lldp_syncd logs tracebacks when LLDP JSON contains unsupported port or chassis ID subtypes (e.g., "unhandled") due to unsafe enum lookups.
Fix: Gracefully handle unsupported LLDP port and chassis ID subtypes in parse_port() and parse_chassis() by validating enum keys and logging ERR without emitting tracebacks.
Related to #24902