Add URL matcher functionality for domain-based application selection by lwille · Pull Request #184 · sonnyp/Junction

lwille · 2025-07-18T11:09:51Z

Summary

This PR implements URL matcher functionality to automatically route URLs to specific applications based on user-defined regex patterns, addressing #75.

Also related to #5.

Key Features

URL Pattern Matching: Users can define regex patterns to match URLs
Automatic Application Selection: Matching URLs automatically open in the configured application
Preferences Integration: New Preferences button in welcome screen for managing URL matchers
GSettings Storage: URL matchers are persisted using GSettings with proper serialization
Libadwaita UI: Modern dialog components following GNOME design guidelines

Implementation Details

Added url-matchers GSettings key for storing JSON-serialized patterns
Implemented getUrlMatchers(), addUrlMatcher(), removeUrlMatcher() functions in util.js
Added findMatchingApp() for automatic URL-to-application matching
Enhanced window.js to check for URL matches before displaying application chooser
Refactored preferences action to use application-level Gio.SimpleAction

Use Cases

Open GitHub URLs in GitHub Desktop: https://github\.com/.*
Route YouTube to media player: https://youtube\.com/.*
Direct documentation to specific browser: https://docs\..*
Route work tools to work browser: .*\.company\.com/.*

Test Coverage

Comprehensive URL pattern matching tests
JSON serialization/deserialization validation
Edge case handling for invalid patterns

Test Plan

Verify Preferences button appears in welcome screen
Test URL matcher creation and deletion via preferences
Confirm automatic URL routing works for HTTP/HTTPS schemes
Validate pattern validation and error handling
Test GSettings persistence across app restarts

Fixes #75

🤖 Generated with Claude Code

- Implement regex-based URL pattern matching for automatic application selection - Add Preferences dialog with URL matcher management interface - Store URL matchers in GSettings with JSON serialization - Add automatic URL routing for HTTP/HTTPS schemes in window.js - Replace deprecated GtkShortcutsWindow with modern Adw.Dialog components - Refactor preferences action to application-level Gio.SimpleAction - Add comprehensive URL matcher test coverage Fixes sonnyp#75

sonnyp · 2025-10-30T09:25:34Z

Thanks, I will review this for Junction 2.0

sonnyp

Merged main and fixed a couple of issues.

The matcher logic needs to be fixed, we don't use Gio.AppInfo anymore

sonnyp · 2025-12-28T15:14:34Z

src/preferences.blp

+
+      Label {
+        label: _("URL Pattern (Regular Expression):");
+        xalign: 0;


please remove all xalign

replace with halign

sonnyp · 2025-12-28T15:15:12Z

src/preferences.js

+  // Add dialog responses
+  add_matcher_dialog.add_response("cancel", "Cancel");
+  add_matcher_dialog.add_response("add", "Add");
+  add_matcher_dialog.set_response_appearance("add", Adw.ResponseAppearance.SUGGESTED);


Suggested change

// Add dialog responses

add_matcher_dialog.add_response("cancel", "Cancel");

add_matcher_dialog.add_response("add", "Add");

add_matcher_dialog.set_response_appearance("add", Adw.ResponseAppearance.SUGGESTED);

add_matcher_dialog.add_response("cancel", "Cancel");

add_matcher_dialog.add_response("add", "Add");

add_matcher_dialog.set_response_appearance("add", Adw.ResponseAppearance.SUGGESTED);

comments shouldn't repeat what the code says

sonnyp · 2025-12-28T15:15:35Z

src/preferences.js

+  add_matcher_dialog.add_response("cancel", "Cancel");
+  add_matcher_dialog.add_response("add", "Add");


Suggested change

add_matcher_dialog.add_response("cancel", "Cancel");

add_matcher_dialog.add_response("add", "Add");

add_matcher_dialog.add_response("cancel", _("Cancel"));

add_matcher_dialog.add_response("add", _("Add"));

sonnyp · 2025-12-28T15:15:51Z

src/preferences.js

+  // Populate browser applications
+  populateAppDropdown();
+
+  // Load existing matchers
+  loadMatchers();


Suggested change

// Populate browser applications

populateAppDropdown();

// Load existing matchers

loadMatchers();

populateAppDropdown();

loadMatchers();

sonnyp · 2025-12-28T15:15:59Z

src/preferences.js

+  // Load existing matchers
+  loadMatchers();
+
+  // Add button handler


Suggested change

// Add button handler

sonnyp · 2025-12-28T15:46:44Z

src/PreferencesDialog.js

+
+      if (pattern && selectedIndex !== Gtk.INVALID_LIST_POSITION) {
+        const appString = app_list_model.get_string(selectedIndex);
+        const [appId] = appString.split(" - ");


too big of a hack

sonnyp · 2025-12-28T15:53:02Z

src/window.blp

+  section {
+    item {
+      label: _("Preferences");
+      action: "app.preferences";
+    }
+  }
+


preferences should have the ctrl+, shortcut

https://developer.gnome.org/hig/reference/keyboard.html

sonnyp · 2025-12-28T15:54:35Z

src/welcome.blp

+      Button {
+        label: _("Preferences");
+        valign: center;
+        halign: center;
+        clicked => $onPreferences();
+      }
+


This doesn't need to be so prominent in the welcome window

Please replace the top right about button with a menu that has Preferences + About

sonnyp · 2025-12-28T15:55:36Z

src/PreferencesDialog.blp

+using Gtk 4.0;
+using Adw 1;
+
+Adw.PreferencesDialog preferences_window {


please move the "Show App Names" menu entry to this Preferences dialog

sonnyp · 2025-12-28T15:56:45Z

src/PreferencesDialog.js

+
+    const deleteButton = new Gtk.Button({
+      icon_name: "user-trash-symbolic",
+      tooltip_text: "Remove URL matcher",


all user visible strings should be marked as translatable

Suggested change

tooltip_text: "Remove URL matcher",

tooltip_text: _("Remove URL matcher"),

sonnyp · 2025-12-28T15:59:44Z

src/PreferencesDialog.blp

+
+Adw.AlertDialog add_matcher_dialog {
+  heading: _("Add URL Matcher");
+  body: _("Enter a regular expression pattern to match URLs and select the application to open them with.");


UI should be self explanatory

Suggested change

body: _("Enter a regular expression pattern to match URLs and select the application to open them with.");

lwille force-pushed the feature/domain-matching branch 4 times, most recently from 1e1d384 to e7ccb13 Compare July 18, 2025 11:33

lwille marked this pull request as ready for review July 18, 2025 11:34

lwille force-pushed the feature/domain-matching branch 2 times, most recently from 41c5de2 to 494de34 Compare July 19, 2025 11:39

lwille force-pushed the feature/domain-matching branch from 494de34 to 641d7c8 Compare July 19, 2025 11:41

This was referenced Jul 19, 2025

Domain Specific Applications Possible? #75

Open

Remember for domain / file type #5

Open

sonnyp added 3 commits December 28, 2025 16:05

Merge branch 'main' into feature/domain-matching

2be971e

Remove duplicate files

e29e382

Post merge fix

c287833

sonnyp requested changes Dec 28, 2025

View reviewed changes

sonnyp reviewed Dec 28, 2025

View reviewed changes

sonnyp added 2 commits January 16, 2026 00:01

Merge branch 'main' into feature/domain-matching

e5aa563

f

0ba8542

		add_matcher_dialog.add_response("cancel", "Cancel");
		add_matcher_dialog.add_response("add", "Add");

	tooltip_text: "Remove URL matcher",
	tooltip_text: _("Remove URL matcher"),

Uh oh!

Conversation

lwille commented Jul 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Key Features

Implementation Details

Use Cases

Test Coverage

Test Plan

Uh oh!

sonnyp commented Oct 30, 2025

Uh oh!

sonnyp left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

lwille commented Jul 18, 2025 •

edited

Loading