Add sender control example to node implementation #478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lo-simon
requested changes
Jan 27, 2026
Comment on lines
+288
to
+289
| const web::json::value touchpoint, | ||
| slog::base_gate & gate) |
Collaborator
There was a problem hiding this comment.
Suggested change
| const web::json::value touchpoint, | |
| slog::base_gate & gate) | |
| const web::json::value& touchpoints) |
Collaborator
There was a problem hiding this comment.
Remove gate, as it is unused. Rename touchpoint to touchpoints and use of reference
| role, | ||
| web::json::value(role), | ||
| U("Sender resource data"), | ||
| touchpoint, |
Collaborator
There was a problem hiding this comment.
Suggested change
| touchpoint, | |
| touchpoints, |
Collaborator
There was a problem hiding this comment.
Rename touchpoint to touchpoints.
Comment on lines
+1518
to
+1519
| value_of({ { nmos::nc::details::make_touchpoint_nmos({nmos::ncp_touchpoint_resource_types::sender, sender_id}) } }), | ||
| gate); |
Collaborator
There was a problem hiding this comment.
Suggested change
| value_of({ { nmos::nc::details::make_touchpoint_nmos({nmos::ncp_touchpoint_resource_types::sender, sender_id}) } }), | |
| gate); | |
| value_of({ { nmos::nc::details::make_touchpoint_nmos({nmos::ncp_touchpoint_resource_types::sender, sender_id}) } })); |
Collaborator
There was a problem hiding this comment.
Remove gate in the earlier make_sender_control suggestion
| const auto sender_controls_block_oid = ++oid; | ||
| auto sender_controls_block = nmos::make_block(sender_controls_block_oid, nmos::root_block_oid, U("sender-controls"), U("Sender Controls"), U("Sender Controls")); | ||
|
|
||
| // example audio sender control(s) |
Collaborator
There was a problem hiding this comment.
Suggested change
| // example audio sender control(s) | |
| // example sender control(s) |
Collaborator
There was a problem hiding this comment.
Now we are creating sender control for all senders, not just audio senders
Comment on lines
+1506
to
+1507
| // only create audio sender controls for audio senders | ||
| //if (impl::ports::audio != port) continue; |
Collaborator
There was a problem hiding this comment.
Suggested change
| // only create audio sender controls for audio senders | |
| //if (impl::ports::audio != port) continue; |
Collaborator
There was a problem hiding this comment.
Remove commented-out code
|
|
||
| utility::ostringstream_t role; | ||
| role << U("sender-control-") << ++count; | ||
| const auto& sender = nmos::find_resource(model.node_resources, sender_id); |
Collaborator
There was a problem hiding this comment.
Suggested change
| const auto& sender = nmos::find_resource(model.node_resources, sender_id); | |
| const auto sender = nmos::find_resource(model.node_resources, sender_id); |
Collaborator
There was a problem hiding this comment.
Prevent danging reference
| sender_controls_block_oid, | ||
| value_of({ { nmos::nc::details::make_touchpoint_nmos({nmos::ncp_touchpoint_resource_types::sender, sender_id}) } }), | ||
| gate); | ||
| // add receiver-monitor to receivers-block |
Collaborator
There was a problem hiding this comment.
Suggested change
| // add receiver-monitor to receivers-block | |
| // add sender-control to sender-controls-block |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An example of a sender control class that represents a complete audio sender.