chore: remove Sora Card feature (versionCode=222)#1253
chore: remove Sora Card feature (versionCode=222)#1253
Conversation
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 383c16a439
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3c56406834
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
25370b6 to
cb74102
Compare
cb74102 to
e480fe5
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ee426570bb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| log "Ensuring required SDK packages (platforms;android-${REQUIRED_API}, build-tools;${REQUIRED_BUILD_TOOLS}, platform-tools, ndk;${REQUIRED_NDK})…" | ||
| "$sm" --install "platforms;android-${REQUIRED_API}" "build-tools;${REQUIRED_BUILD_TOOLS}" "platform-tools" "ndk;${REQUIRED_NDK}" |
There was a problem hiding this comment.
Install Android 36 platform in local validation script
The local validation flow now runs Gradle tasks against compileSdkVersion = 36 (build.gradle), but this script still installs platforms;android-${REQUIRED_API} where REQUIRED_API remains 35, so a fresh environment that follows scripts/validate-local.sh can still fail during compilation with missing Android 36 platform errors. Please align the required SDK platform with the compile SDK to keep the documented validation path working.
Useful? React with 👍 / 👎.
| exit 1 | ||
| fi | ||
|
|
||
| TOOLCHAIN="${ANDROID_NDK_HOME}/toolchains/llvm/prebuilt/darwin-x86_64" |
There was a problem hiding this comment.
Detect host NDK toolchain path dynamically
The libsodium rebuild script hardcodes prebuilt/darwin-x86_64, which makes it exit immediately on non-macOS hosts where the NDK toolchain directory is linux-x86_64 (or Windows equivalent), so the new rebuild workflow is unusable for Linux-based developers/CI. Please derive the host prebuilt directory dynamically instead of pinning a macOS path.
Useful? React with 👍 / 👎.
Summary
Describe the change and why it’s needed.
Related Issue
Closes # (or) Relates to #
Type of Change
Screenshots / Videos
If UI changes, include before/after.
Test Plan
Commands run locally:
Additional checks and scenarios covered:
Risks & Rollout
Potential impact, migrations, or config/secrets required.
Checklist