Skip to content

chore: remove Sora Card feature (versionCode=222)#1253

Open
WRRicht3r wants to merge 6 commits intodevelopfrom
chore/16kb-page-support
Open

chore: remove Sora Card feature (versionCode=222)#1253
WRRicht3r wants to merge 6 commits intodevelopfrom
chore/16kb-page-support

Conversation

@WRRicht3r
Copy link
Contributor

@WRRicht3r WRRicht3r commented Mar 10, 2026

Summary

Describe the change and why it’s needed.

Related Issue

Closes # (or) Relates to #

Type of Change

  • feat (new feature)
  • fix (bug fix)
  • refactor (no functional change)
  • chore/build (tooling, CI, deps)
  • docs (README/AGENTS, comments)

Screenshots / Videos

If UI changes, include before/after.

Test Plan

Commands run locally:

./gradlew detektAll
./gradlew runTest
./gradlew :app:lint

Additional checks and scenarios covered:

Risks & Rollout

Potential impact, migrations, or config/secrets required.

Checklist

  • Linked an issue and added a clear description
  • Added/updated tests for changed code (where applicable)
  • Updated docs (README/AGENTS) when behavior or commands changed
  • Ran detektAll, runTest, and :app:lint locally (or via CI)
  • No secrets or local.properties committed

@takemiyamakoto
Copy link
Contributor

@codex review

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 383c16a439

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@takemiyamakoto
Copy link
Contributor

@codex review

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3c56406834

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@WRRicht3r WRRicht3r force-pushed the chore/16kb-page-support branch 4 times, most recently from 25370b6 to cb74102 Compare March 13, 2026 10:06
@WRRicht3r WRRicht3r force-pushed the chore/16kb-page-support branch from cb74102 to e480fe5 Compare March 13, 2026 10:18
@takemiyamakoto
Copy link
Contributor

@codex review

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ee426570bb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +76 to +77
log "Ensuring required SDK packages (platforms;android-${REQUIRED_API}, build-tools;${REQUIRED_BUILD_TOOLS}, platform-tools, ndk;${REQUIRED_NDK})…"
"$sm" --install "platforms;android-${REQUIRED_API}" "build-tools;${REQUIRED_BUILD_TOOLS}" "platform-tools" "ndk;${REQUIRED_NDK}"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Install Android 36 platform in local validation script

The local validation flow now runs Gradle tasks against compileSdkVersion = 36 (build.gradle), but this script still installs platforms;android-${REQUIRED_API} where REQUIRED_API remains 35, so a fresh environment that follows scripts/validate-local.sh can still fail during compilation with missing Android 36 platform errors. Please align the required SDK platform with the compile SDK to keep the documented validation path working.

Useful? React with 👍 / 👎.

exit 1
fi

TOOLCHAIN="${ANDROID_NDK_HOME}/toolchains/llvm/prebuilt/darwin-x86_64"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Detect host NDK toolchain path dynamically

The libsodium rebuild script hardcodes prebuilt/darwin-x86_64, which makes it exit immediately on non-macOS hosts where the NDK toolchain directory is linux-x86_64 (or Windows equivalent), so the new rebuild workflow is unusable for Linux-based developers/CI. Please derive the host prebuilt directory dynamically instead of pinning a macOS path.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants