Fix handleTouchEnd called not after a handleTouchStart#114
Open
serut wants to merge 2 commits intosouhe:masterfrom
Open
Fix handleTouchEnd called not after a handleTouchStart#114serut wants to merge 2 commits intosouhe:masterfrom
serut wants to merge 2 commits intosouhe:masterfrom
Conversation
gulp is not provided globally by npm ...!
Author
|
I thought at first one of my issue came from your lib, so I fix it. But in fact it was something else. Anyway, you should merge it to prevent people using Chrome debugger to see that issue and loose some time on it as that event can be safely ignored. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In my application, when I click the first time inside the scrollbar with a Chrome under mobile emulation, the event
handleTouchEndis called but nohandleTouchStart.This PR protects the
handleTouchEndevent handler to throw that exception, sincethis.eventPreviousValuesis undefined: