-
Notifications
You must be signed in to change notification settings - Fork 31
Update dependency mqtt to v5 #426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
7a36e38 to
4c6d157
Compare
54233f9 to
8b712f4
Compare
08941b6 to
771a051
Compare
c124819 to
59c7332
Compare
83020d9 to
4d4c4ba
Compare
fe657b9 to
61926f6
Compare
61926f6 to
31ca2e8
Compare
| "private": true, | ||
| "dependencies": { | ||
| "mqtt": "^4.3.7", | ||
| "mqtt": "^5.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: The mqtt package was upgraded to v5, which requires using the new keyword with connect. The current code calls connect(link) without new, which will cause a runtime error.
Severity: CRITICAL
Suggested Fix
The mqtt.js v5 library requires instantiation with the new keyword. Update the client connection logic in src/bundles/communication/src/MqttController.ts from this.client = connect(link); to correctly instantiate the client according to the v5 API. The import might also need to be adjusted.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: src/bundles/communication/package.json#L6
Potential issue: The `mqtt` dependency was upgraded from v4.3.7 to v5.x. This major
version upgrade introduced a breaking change where creating an `MqttClient` instance now
requires the `new` keyword. The code in
`src/bundles/communication/src/MqttController.ts` at line 45 calls `this.client =
connect(link)` without the `new` keyword. This will result in a runtime error when the
`connectClient()` method is invoked, preventing any MQTT connection from being
established and breaking all communication functionality for that bundle.
Did we get this right? 👍 / 👎 to inform future reviews.
This PR contains the following updates:
^4.3.7→^5.0.0Release Notes
mqttjs/MQTT.js (mqtt)
v5.14.1Compare Source
Bug Fixes
v5.14.0Compare Source
5.13.2 (2025-07-07)
Bug Fixes
5.13.1 (2025-06-03)
v5.13.3Compare Source
5.13.2 (2025-07-07)
Bug Fixes
5.13.1 (2025-06-03)
v5.13.2Compare Source
5.13.2 (2025-07-07)
Bug Fixes
5.13.1 (2025-06-03)
v5.13.1Compare Source
5.13.2 (2025-07-07)
Bug Fixes
5.13.1 (2025-06-03)
v5.13.0Compare Source
5.13.2 (2025-07-07)
Bug Fixes
5.13.1 (2025-06-03)
v5.12.1Compare Source
Features
subscribeBatchSizeoption to split subscribe packets for AWS IoT Core (#1995) (6b719c8)5.12.1 (2025-05-06)
Bug Fixes
@typescript-eslint/consistent-type-importsrule and normalised all imports (640cd3b)v5.12.0Compare Source
Features
subscribeBatchSizeoption to split subscribe packets for AWS IoT Core (#1995) (6b719c8)5.12.1 (2025-05-06)
Bug Fixes
@typescript-eslint/consistent-type-importsrule and normalised all imports (640cd3b)v5.11.1Compare Source
Features
5.11.1 (2025-04-23)
Bug Fixes
v5.11.0Compare Source
Features
5.11.1 (2025-04-23)
Bug Fixes
v5.10.4Compare Source
Bug Fixes
validateTopisto includenull(#1979) (935784a)Features
5.10.4 (2025-02-26)
Bug Fixes
5.10.3 (2024-11-26)
Bug Fixes
5.10.2 (2024-11-13)
Features
5.10.1 (2024-08-28)
Bug Fixes
Blobpayloads (#1930) (86b7959)v5.10.3Compare Source
Bug Fixes
validateTopisto includenull(#1979) (935784a)Features
5.10.4 (2025-02-26)
Bug Fixes
5.10.3 (2024-11-26)
Bug Fixes
5.10.2 (2024-11-13)
Features
5.10.1 (2024-08-28)
Bug Fixes
Blobpayloads (#1930) (86b7959)v5.10.2Compare Source
Bug Fixes
validateTopisto includenull(#1979) (935784a)Features
5.10.4 (2025-02-26)
Bug Fixes
5.10.3 (2024-11-26)
Bug Fixes
5.10.2 (2024-11-13)
Features
5.10.1 (2024-08-28)
Bug Fixes
Blobpayloads (#1930) (86b7959)v5.10.1Compare Source
Bug Fixes
validateTopisto includenull(#1979) (935784a)Features
5.10.4 (2025-02-26)
Bug Fixes
5.10.3 (2024-11-26)
Bug Fixes
5.10.2 (2024-11-13)
Features
5.10.1 (2024-08-28)
Bug Fixes
Blobpayloads (#1930) (86b7959)v5.10.0Compare Source
Bug Fixes
validateTopisto includenull(#1979) (935784a)Features
5.10.4 (2025-02-26)
Bug Fixes
5.10.3 (2024-11-26)
Bug Fixes
5.10.2 (2024-11-13)
Features
5.10.1 (2024-08-28)
Bug Fixes
Blobpayloads (#1930) (86b7959)v5.9.1Compare Source
Bug Fixes
Features
subackpacket to subscribe callback (#1923) (93f4482)5.9.1 (2024-08-01)
Bug Fixes
stream.push() after EOF(#1915) (b5cc835), closes #1914v5.9.0Compare Source
Bug Fixes
Features
subackpacket to subscribe callback (#1923) (93f4482)5.9.1 (2024-08-01)
Bug Fixes
stream.push() after EOF(#1915) (b5cc835), closes #1914v5.8.1Compare Source
Bug Fixes
Features
forceNativeWebSocketclient option (#1910) (103d172), closes #1796 #18955.8.1 (2024-07-18)
Bug Fixes
v5.8.0Compare Source
Bug Fixes
Features
forceNativeWebSocketclient option (#1910) (103d172), closes #1796 #18955.8.1 (2024-07-18)
Bug Fixes
v5.7.3Compare Source
Features
5.7.3 (2024-06-26)
Bug Fixes
wxprotocol (#1894) (300c0b4), closes #18925.7.2 (2024-06-19)
Bug Fixes
5.7.1 (2024-06-18)
Bug Fixes
v5.7.2Compare Source
Features
5.7.3 (2024-06-26)
Bug Fixes
wxprotocol (#1894) (300c0b4), closes #18925.7.2 (2024-06-19)
Bug Fixes
5.7.1 (2024-06-18)
Bug Fixes
v5.7.1Compare Source
Features
5.7.3 (2024-06-26)
Bug Fixes
wxprotocol (#1894) (300c0b4), closes #18925.7.2 (2024-06-19)
Bug Fixes
5.7.1 (2024-06-18)
Bug Fixes
v5.7.0Compare Source
Features
5.7.3 (2024-06-26)
Bug Fixes
wxprotocol (#1894) (300c0b4), closes #18925.7.2 (2024-06-19)
Bug Fixes
5.7.1 (2024-06-18)
Bug Fixes
v5.6.2Compare Source
Features
unixSocketoption and+unixsuffix support to protocol (#1874) (1004c78)5.6.2 (2024-05-23)
Bug Fixes
pathoption (#1871) (de0174f), closes #18705.6.1 (2024-05-17)
Bug Fixes
undefinednavigator (#1868) (0111a7a), closes /github.com/mqttjs/MQTT.js/commit/6a03d29b86dc4fe8eae04eaf0f9fc661f1c3d1ea#commitcomment-142114121 /github.com/mqttjs/MQTT.js/pull/1868#pullrequestreview-2062507553v5.6.1Compare Source
Features
unixSocketoption and+unixsuffix support to protocol (#1874) (1004c78)5.6.2 (2024-05-23)
Bug Fixes
pathoption (#1871) (de0174f), closes #18705.6.1 (2024-05-17)
Bug Fixes
undefinednavigator (#1868) (0111a7a), closes /github.com/mqttjs/MQTT.js/commit/6a03d29b86dc4fe8eae04eaf0f9fc661f1c3d1ea#commitcomment-142114121 /github.com/mqttjs/MQTT.js/pull/1868#pullrequestreview-2062507553v5.6.0Compare Source
Features
unixSocketoption and+unixsuffix support to protocol (#1874) (1004c78)5.6.2 (2024-05-23)
Bug Fixes
pathoption (#1871) (de0174f), closes #18705.6.1 (2024-05-17)
Bug Fixes
undefinednavigator (#1868) (0111a7a), closes /github.com/mqttjs/MQTT.js/commit/6a03d29b86dc4fe8eae04eaf0f9fc661f1c3d1ea#commitcomment-142114121 /github.com/mqttjs/MQTT.js/pull/1868#pullrequestreview-2062507553v5.5.6Compare Source
Features
5.5.6 (2024-05-13)
Bug Fixes
hostoption and default hostname in browser (c6580a6), closes #17305.5.5 (2024-04-30)
Bug Fixes
5.5.4 (2024-04-26)
Bug Fixes
5.5.3 (2024-04-19)
Bug Fixes
5.5.2 (2024-04-12)
Bug Fixes
5.5.1 (2024-04-10)
Bug Fixes
v5.5.5Compare Source
Features
5.5.6 (2024-05-13)
Bug Fixes
hostoption and default hostname in browser (c6580a6), closes #17305.5.5 (2024-04-30)
Bug Fixes
5.5.4 (2024-04-26)
Bug Fixes
5.5.3 (2024-04-19)
Bug Fixes
5.5.2 (2024-04-12)
Bug Fixes
5.5.1 (2024-04-10)
Bug Fixes
v5.5.4Compare Source
Features
5.5.6 (2024-05-13)
Bug Fixes
hostoption and default hostname in browser (c6580a6), closes #17305.5.5 (2024-04-30)
Bug Fixes
5.5.4 (2024-04-26)
Bug Fixes
5.5.3 (2024-04-19)
Bug Fixes
5.5.2 (2024-04-12)
Bug Fixes
5.5.1 (2024-04-10)
Bug Fixes
v5.5.3Compare Source
Features
5.5.6 (2024-05-13)
Bug Fixes
hostoption and default hostname in browser (c6580a6), closes #17305.5.5 (2024-04-30)
Bug Fixes
5.5.4 (2024-04-26)
Bug Fixes
5.5.3 (2024-04-19)
Bug Fixes
5.5.2 (2024-04-12)
Bug Fixes
5.5.1 (2024-04-10)
Bug Fixes
v5.5.2Compare Source
Features
5.5.6 (2024-05-13)
Bug Fixes
hostoption and default hostname in browser (c6580a6), closes #17305.5.5 (2024-04-30)
Bug Fixes
5.5.4 (2024-04-26)
Bug Fixes
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.