Skip to content

fix: don't print credentials to stdout on login unless --no-cache #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alukach merged 1 commit into from
Jun 26, 2026
Merged

fix: don't print credentials to stdout on login unless --no-cache #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,18 +144,18 @@ async fn run_login(args: LoginArgs, verbose: bool) -> Result<(), String> {
)
.await?;

// 4. Cache credentials
// 4. Cache credentials, or print to stdout when caching is skipped.
// Default path stays quiet so `login` doesn't leak credentials to the terminal.
if args.no_cache {
eprintln!("Skipping credential cache (--no-cache)");
match args.format {
OutputFormat::CredentialProcess => output::print_credential_process(&creds),
OutputFormat::Env => output::print_env(&creds),
}
} else {
let location = cache::write_credentials(&args.role_arn, &creds)?;
eprintln!("Credentials cached to {location}");
}

// 5. Output
match args.format {
OutputFormat::CredentialProcess => output::print_credential_process(&creds),
OutputFormat::Env => output::print_env(&creds),
eprintln!("Run 'source-coop creds' to print them.");
}

Ok(())
Expand Down
Loading