Skip to content
This repository was archived by the owner on Aug 15, 2019. It is now read-only.

Display Minutes Listing#44

Open
trickeydan wants to merge 5 commits into
masterfrom
display-minutes
Open

Display Minutes Listing#44
trickeydan wants to merge 5 commits into
masterfrom
display-minutes

Conversation

@trickeydan

Copy link
Copy Markdown
Collaborator

This PR will display a listing of links to the minutes.

It will auto-update without changing this repo if a webhook is added to rebuild the site on Netlify. A similar suggestion was discussed in #25.

NB: Build is failing due to the spelling check script displaying odd behaviour. It doesn't accept the list as sorted even after the sort.sh is run.

nmalky
nmalky previously requested changes Apr 1, 2018

@nmalky nmalky left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that we have build-online.sh, what is the purpose of build.sh?
If there isn't any, it should be deleted, and all instances of build.sh removed (e.g. README.md hasn't been changed to build-online.sh)

@trickeydan trickeydan dismissed nmalky’s stale review April 1, 2018 11:16

build-online.sh ignores the cache and is thus purposed for rendering the latest version of the site on Netlify / CircleCI. build.sh doesn't ignore the cache and thus builds significantly quicker for development purposes.

@RealOrangeOne

Copy link
Copy Markdown
Member

Why do we need the minutes baked into the site? Surely linking to the repo is enough? This means that the site has to be re-deployed every week so the list updates, even if nothing has changed. Just linking is a far nicer solution!

@trickeydan

Copy link
Copy Markdown
Collaborator Author

I would argue that this makes the minutes more accessible to people unfamiliar with GitHub. If the webhook is called when new content is pushed to the minutes repo, then it has changed.

Also, as it only takes seconds to re-deploy the website, why would this be a problem?

@RealOrangeOne

RealOrangeOne commented Apr 1, 2018

Copy link
Copy Markdown
Member

more accessible to people unfamiliar with GitHub

They don't need to know about GitHub, or how it works. Assuming they understand the concept of folders and files, they can traverse the web UI. The web UI is incredibly easy to use, by design! I fail to see how this is any different?

why would this be a problem

Because, it's another build step, and another way to get outdated. It's theoretically possible to force the website to redeploy, it's still a hack

@trickeydan

Copy link
Copy Markdown
Collaborator Author

It's not a hack, it's listed on their docs!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants