lint: add incoherent_exclusive_limits rule

[AcEKaycgR]

Summary

Adds a new lint rule incoherent_exclusive_limits that fires when exclusiveMinimum is greater than or equal to exclusiveMaximum, making the schema unsatisfiable.

Applies to Draft 6, Draft 7, 2019-09, and 2020-12.

Test cases (per dialect)

• Valid: exclusiveMinimum < exclusiveMaximum
• Valid: only exclusiveMinimum present
• Valid: only exclusiveMaximum present
• Invalid: exclusiveMinimum == exclusiveMaximum
• Invalid: exclusiveMinimum > exclusiveMaximum

Changes

• src/alterschema/linter/incoherent_exclusive_limits.h - new rule
• src/alterschema/alterschema.cc - rule registered for all four dialects
• src/alterschema/CMakeLists.txt - header added
• test/alterschema/alterschema_lint_draft6_test.cc - tests added
• test/alterschema/alterschema_lint_draft7_test.cc - tests added
• test/alterschema/alterschema_lint_2019_09_test.cc - tests added
• test/alterschema/alterschema_lint_2020_12_test.cc - tests added

Part of sourcemeta/core#1975.

[augmentcode]

🤖 Augment PR Summary

Summary: This PR introduces a new linter rule, incoherent_exclusive_limits, to detect contradictory numeric-exclusive bounds in JSON Schemas.

Changes:

• Added IncoherentExclusiveLimits rule that triggers when exclusiveMinimum is greater than or equal to exclusiveMaximum
• Registered the rule in the AlterSchema linter bundle so it runs during lint mode
• Updated AlterSchema CMake source list to include the new header
• Added test coverage for Draft 7, 2019-09, and 2020-12 covering coherent, missing-bound, and incoherent-bound cases

Technical Notes: The rule is non-mutating (lint-only) and reports both keywords as implicated when it fires.

_{🤖 Was this summary useful? React with 👍 or 👎}

[augmentcode]

Review completed. 2 suggestions posted.

Comment augment review to trigger a new review at any time.

[cubic-dev-ai]

2 issues found across 6 files

<sub>Reply with feedback, questions, or to request a fix.

Re-trigger cubic</sub>

[jviotti]

I think this one is a good one to have in the common folder for both the linter and canonicalizer (and testing on both), and having a transform that sets the current schema to false or just adds not: true or whatever to make the unsatisfiability obvious.

I believe we have some rules that do something like this for you to take inspiration from

[AcEKaycgR]

Updated as suggested. The rule is now in src/alterschema/common/ with mutates = std::true_type and a transform that sets the schema to false. It is registered under both the linter and canonicalizer bundles, and canonicalizer tests have been added for all four dialects alongside the existing lint tests.