Skip to content

Fix Windows UNC support on URI::to_path()#2388

Merged
jviotti merged 2 commits into
mainfrom
unc-paths
May 19, 2026
Merged

Fix Windows UNC support on URI::to_path()#2388
jviotti merged 2 commits into
mainfrom
unc-paths

Conversation

@jviotti
Copy link
Copy Markdown
Member

@jviotti jviotti commented May 19, 2026

Signed-off-by: Juan Cruz Viotti jv@jviotti.com

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
@augmentcode
Copy link
Copy Markdown

augmentcode Bot commented May 19, 2026

🤖 Augment PR Summary

Summary: Improves Windows UNC support in URI::to_path() for file:// URIs.

Changes:

  • Recognizes non-empty, non-localhost hosts in file:// URIs as UNC servers (RFC 8089) and formats them as \\server\share\... paths.
  • Converts separators and percent-decodes the UNC path component before returning.
  • Adds unit tests for UNC paths (simple/space/Unicode) and for treating file://localhost as “no host”.

🤖 Was this summary useful? React with 👍 or 👎

Copy link
Copy Markdown

@augmentcode augmentcode Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 1 suggestion posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

Comment thread src/core/uri/filesystem.cc Outdated
Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 2 files

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread src/core/uri/filesystem.cc Outdated
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (linux/llvm)

Details
Benchmark suite Current: c98ca74 Previous: fc0dd4e Ratio
Regex_Lower_S_Or_Upper_S_Asterisk 2.4643611505203706 ns/iter 2.2150761870085134 ns/iter 1.11
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 2.5082847242998247 ns/iter 2.1948289246950887 ns/iter 1.14
Regex_Period_Asterisk 2.4613616580034927 ns/iter 2.1888612363008466 ns/iter 1.12
Regex_Group_Period_Asterisk_Group 2.4607521219254194 ns/iter 2.186355286006275 ns/iter 1.13
Regex_Period_Plus 3.8684258893202887 ns/iter 2.8123089678662168 ns/iter 1.38
Regex_Period 3.5274586711546436 ns/iter 2.491208907411753 ns/iter 1.42
Regex_Caret_Period_Plus_Dollar 2.4615141697808145 ns/iter 2.8057837561929015 ns/iter 0.88
Regex_Caret_Group_Period_Plus_Group_Dollar 2.4618591223435815 ns/iter 2.236367931443495 ns/iter 1.10
Regex_Caret_Period_Asterisk_Dollar 3.8663080099967226 ns/iter 2.4907799800231367 ns/iter 1.55
Regex_Caret_Group_Period_Asterisk_Group_Dollar 3.5156066342778485 ns/iter 2.190919993779683 ns/iter 1.60
Regex_Caret_X_Hyphen 7.10403448738863 ns/iter 6.85289894142752 ns/iter 1.04
Regex_Period_Md_Dollar 27.897824369066594 ns/iter 27.308998972785908 ns/iter 1.02
Regex_Caret_Slash_Period_Asterisk 7.380402897602069 ns/iter 6.227661358691763 ns/iter 1.19
Regex_Caret_Period_Range_Dollar 3.8675679755747217 ns/iter 3.734922903315442 ns/iter 1.04
Regex_Nested_Backtrack 37.43496389536534 ns/iter 37.31713759694607 ns/iter 1.00
JSON_Array_Of_Objects_Unique 416.4579859988931 ns/iter 385.94925525852796 ns/iter 1.08
JSON_Parse_1 5570.75651551259 ns/iter 5897.990595142556 ns/iter 0.94
JSON_Parse_Real 10138.72384154898 ns/iter 11172.54199344157 ns/iter 0.91
JSON_Parse_Decimal 11107.790706923206 ns/iter 11134.799282410211 ns/iter 1.00
JSON_Parse_Schema_ISO_Language 3604190.6875000265 ns/iter 3674980.0414512143 ns/iter 0.98
JSON_Fast_Hash_Helm_Chart_Lock 65.38466056837841 ns/iter 53.83380959269923 ns/iter 1.21
JSON_Equality_Helm_Chart_Lock 162.9237430750201 ns/iter 164.28705212186642 ns/iter 0.99
JSON_Divisible_By_Decimal 245.10708581884248 ns/iter 245.42450909481542 ns/iter 1.00
JSON_String_Equal/10 6.0452289887046256 ns/iter 6.230940569429897 ns/iter 0.97
JSON_String_Equal/100 6.686174028335562 ns/iter 6.8545890877079545 ns/iter 0.98
JSON_String_Equal_Small_By_Perfect_Hash/10 1.0685808945492223 ns/iter 0.9367728198479524 ns/iter 1.14
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 12.483428963532365 ns/iter 10.272940459758466 ns/iter 1.22
JSON_String_Fast_Hash/10 2.109882207810128 ns/iter 2.1846815626451375 ns/iter 0.97
JSON_String_Fast_Hash/100 2.1090481910275645 ns/iter 2.1811733426893953 ns/iter 0.97
JSON_String_Key_Hash/10 2.461738862235392 ns/iter 2.194485338763624 ns/iter 1.12
JSON_String_Key_Hash/100 8.084741995457666 ns/iter 6.536546408088413 ns/iter 1.24
JSON_Object_Defines_Miss_Same_Length 4.219478677743398 ns/iter 3.738463735067338 ns/iter 1.13
JSON_Object_Defines_Miss_Too_Small 4.222179188514648 ns/iter 3.7395204773994895 ns/iter 1.13
JSON_Object_Defines_Miss_Too_Large 4.2196988319794615 ns/iter 3.739281448240995 ns/iter 1.13
Pointer_Object_Traverse 27.2542466803839 ns/iter 24.844073037211277 ns/iter 1.10
Pointer_Object_Try_Traverse 30.86881549724778 ns/iter 26.301016784479856 ns/iter 1.17
Pointer_Push_Back_Pointer_To_Weak_Pointer 206.74213096179267 ns/iter 164.8484338661554 ns/iter 1.25
Pointer_Walker_Schema_ISO_Language 3204460.6774195316 ns/iter 3455923.101009922 ns/iter 0.93
Pointer_Maybe_Tracked_Deeply_Nested/0 1424051.9386503513 ns/iter 1469122.6300212378 ns/iter 0.97
Pointer_Maybe_Tracked_Deeply_Nested/1 1699476.4323672114 ns/iter 1781193.1198980696 ns/iter 0.95
Pointer_Position_Tracker_Get_Deeply_Nested 723.8498676711878 ns/iter 646.8430845901023 ns/iter 1.12
Schema_Frame_WoT_References 5346311.519083984 ns/iter 5443044.684614927 ns/iter 0.98
Schema_Frame_OMC_References 22701355.741934355 ns/iter 24972110.57143188 ns/iter 0.91
Schema_Frame_OMC_Locations 20813426.029412635 ns/iter 22836500.70967636 ns/iter 0.91
Schema_Frame_ISO_Language_Locations 100651511.00000472 ns/iter 110013420.16665679 ns/iter 0.91
Schema_Frame_KrakenD_References 40862204.0588264 ns/iter 47312883.066661015 ns/iter 0.86
Schema_Frame_KrakenD_Reachable 626702593.9999939 ns/iter 719949037.9999815 ns/iter 0.87
Schema_Iterator_ISO_Language 3080913.407239673 ns/iter 3143380.246636689 ns/iter 0.98
Schema_Frame_ISO_Language_Locations_To_JSON 115646035.3333273 ns/iter 115693034.00000308 ns/iter 1.00
Schema_Tracker_ISO_Language 4488286.33766233 ns/iter 5134773.941606404 ns/iter 0.87
Schema_Tracker_ISO_Language_To_JSON 18298269.52631433 ns/iter 19908511.08823389 ns/iter 0.92
Schema_Format_ISO_Language_To_JSON 117639993.2000095 ns/iter 118140405.83336312 ns/iter 1.00
Schema_Bundle_Meta_2020_12 1705046.4417442288 ns/iter 1700099.2493951637 ns/iter 1.00
Schema_Frame_Many_Resources_References 389193736.4999762 ns/iter 396619334.50003064 ns/iter 0.98
EditorSchema_ForEditor_EmbeddedResources 14615972.540007079 ns/iter 14829425.695638847 ns/iter 0.99
URITemplateRouter_Create 29912.383724421834 ns/iter 32515.39226673306 ns/iter 0.92
URITemplateRouter_Match 184.22088327784945 ns/iter 178.21441420609833 ns/iter 1.03
URITemplateRouter_Match_BasePath 219.95777084720478 ns/iter 203.93005939620033 ns/iter 1.08
URITemplateRouterView_Restore 8762.258556851713 ns/iter 7745.0108731961145 ns/iter 1.13
URITemplateRouterView_Match 144.5949173696573 ns/iter 146.34573522263514 ns/iter 0.99
URITemplateRouterView_Match_BasePath 165.34107851791765 ns/iter 165.25702100560056 ns/iter 1.00
URITemplateRouterView_Arguments 471.51188138898493 ns/iter 431.8083257116326 ns/iter 1.09
JSONL_Parse_Large 9735651.319445537 ns/iter 10727077.061539184 ns/iter 0.91
JSONL_Parse_Large_GZIP 11168288.365079135 ns/iter 11916932.016948383 ns/iter 0.94
HTML_Build_Table_100000 88191425.37500113 ns/iter 66271791.00000417 ns/iter 1.33
HTML_Render_Table_100000 5965432.30578526 ns/iter 6295423.112068623 ns/iter 0.95
GZIP_Compress_ISO_Language_Set_3_Locations 36721367.6842144 ns/iter 35224533.40000311 ns/iter 1.04
GZIP_Decompress_ISO_Language_Set_3_Locations 5113768.1386865685 ns/iter 5830727.837398508 ns/iter 0.88
GZIP_Compress_ISO_Language_Set_3_Schema 2144562.2546013477 ns/iter 1919554.8379119313 ns/iter 1.12
GZIP_Decompress_ISO_Language_Set_3_Schema 295008.254201697 ns/iter 379186.4265582844 ns/iter 0.78

This comment was automatically generated by workflow using github-action-benchmark.

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (windows/msvc)

Details
Benchmark suite Current: c98ca74 Previous: fc0dd4e Ratio
Regex_Lower_S_Or_Upper_S_Asterisk 8.880697728212313 ns/iter 6.834759999999277 ns/iter 1.30
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 8.826590585596295 ns/iter 6.870655357143311 ns/iter 1.28
Regex_Period_Asterisk 8.867610228269678 ns/iter 6.8395776785722875 ns/iter 1.30
Regex_Group_Period_Asterisk_Group 8.823732549893153 ns/iter 6.840133035715163 ns/iter 1.29
Regex_Period_Plus 11.313704687498927 ns/iter 8.749900669641367 ns/iter 1.29
Regex_Period 11.28444375000015 ns/iter 8.742528978830526 ns/iter 1.29
Regex_Caret_Period_Plus_Dollar 11.282546428568757 ns/iter 8.739688353840178 ns/iter 1.29
Regex_Caret_Group_Period_Plus_Group_Dollar 11.29406718749948 ns/iter 8.744882103820018 ns/iter 1.29
Regex_Caret_Period_Asterisk_Dollar 8.826744603450077 ns/iter 6.834495535715388 ns/iter 1.29
Regex_Caret_Group_Period_Asterisk_Group_Dollar 8.824460937500842 ns/iter 6.834626785713941 ns/iter 1.29
Regex_Caret_X_Hyphen 13.757168911800711 ns/iter 10.66389531250067 ns/iter 1.29
Regex_Period_Md_Dollar 40.56319831111261 ns/iter 31.25056008649955 ns/iter 1.30
Regex_Caret_Slash_Period_Asterisk 13.050432142855634 ns/iter 10.116099061980652 ns/iter 1.29
Regex_Caret_Period_Range_Dollar 11.281559374999972 ns/iter 8.868909335404977 ns/iter 1.27
Regex_Nested_Backtrack 50.04891999999472 ns/iter 38.7900279017853 ns/iter 1.29
JSON_Array_Of_Objects_Unique 490.6923999999435 ns/iter 382.2961599239178 ns/iter 1.28
JSON_Parse_1 7607.492187501817 ns/iter 5981.13499999954 ns/iter 1.27
JSON_Parse_Real 13957.76246534754 ns/iter 10908.512499998578 ns/iter 1.28
JSON_Parse_Decimal 16184.5669642854 ns/iter 11223.417187498086 ns/iter 1.44
JSON_Parse_Schema_ISO_Language 6421883.928571301 ns/iter 5213146.428571592 ns/iter 1.23
JSON_Fast_Hash_Helm_Chart_Lock 58.596687499995625 ns/iter 47.6640948139254 ns/iter 1.23
JSON_Equality_Helm_Chart_Lock 283.35634895728185 ns/iter 220.8111562499937 ns/iter 1.28
JSON_Divisible_By_Decimal 255.54171428569006 ns/iter 201.46908698797498 ns/iter 1.27
JSON_String_Equal/10 11.729310714287067 ns/iter 9.057909598213191 ns/iter 1.29
JSON_String_Equal/100 13.124512500001272 ns/iter 10.19277812499908 ns/iter 1.29
JSON_String_Equal_Small_By_Perfect_Hash/10 2.1178227431727126 ns/iter 1.4563752232145282 ns/iter 1.45
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 11.872844642860109 ns/iter 8.793021389317836 ns/iter 1.35
JSON_String_Fast_Hash/10 3.691090959820898 ns/iter 2.514940713162382 ns/iter 1.47
JSON_String_Fast_Hash/100 3.5642062890737836 ns/iter 2.4934017829313917 ns/iter 1.43
JSON_String_Key_Hash/10 4.75365603743572 ns/iter 3.57083008370556 ns/iter 1.33
JSON_String_Key_Hash/100 17.45042198135681 ns/iter 13.118094642858782 ns/iter 1.33
JSON_Object_Defines_Miss_Same_Length 3.9645351410071568 ns/iter 3.0231236607138254 ns/iter 1.31
JSON_Object_Defines_Miss_Too_Small 5.448402678573367 ns/iter 3.849651227678663 ns/iter 1.42
JSON_Object_Defines_Miss_Too_Large 3.8893063616082406 ns/iter 3.005524750438804 ns/iter 1.29
Pointer_Object_Traverse 42.87434375000032 ns/iter 32.81311926270769 ns/iter 1.31
Pointer_Object_Try_Traverse 53.189210000005005 ns/iter 40.93191081605935 ns/iter 1.30
Pointer_Push_Back_Pointer_To_Weak_Pointer 167.66113839286692 ns/iter 116.37485937498583 ns/iter 1.44
Pointer_Walker_Schema_ISO_Language 12598757.142857915 ns/iter 10743116.000000251 ns/iter 1.17
Pointer_Maybe_Tracked_Deeply_Nested/0 2076340.7142851518 ns/iter 1649740.5797100076 ns/iter 1.26
Pointer_Maybe_Tracked_Deeply_Nested/1 3107024.5535715916 ns/iter 2366721.7391300974 ns/iter 1.31
Pointer_Position_Tracker_Get_Deeply_Nested 657.6209821430114 ns/iter 487.5748214284872 ns/iter 1.35
Schema_Frame_WoT_References 10441897.333333448 ns/iter 8339082.222222613 ns/iter 1.25
Schema_Frame_OMC_References 46732373.333331145 ns/iter 39383377.77777987 ns/iter 1.19
Schema_Frame_OMC_Locations 41314323.52940411 ns/iter 31497657.14285769 ns/iter 1.31
Schema_Frame_ISO_Language_Locations 205973333.33330426 ns/iter 156240939.99999785 ns/iter 1.32
Schema_Frame_KrakenD_References 93629285.71428192 ns/iter 72193455.55555871 ns/iter 1.30
Schema_Frame_KrakenD_Reachable 548019599.9998614 ns/iter 407445849.9999309 ns/iter 1.35
Schema_Iterator_ISO_Language 6846768.749998741 ns/iter 5260385.714285982 ns/iter 1.30
Schema_Frame_ISO_Language_Locations_To_JSON 321690199.9999209 ns/iter 242214066.6666716 ns/iter 1.33
Schema_Tracker_ISO_Language 9894269.333332583 ns/iter 7780542.222220295 ns/iter 1.27
Schema_Tracker_ISO_Language_To_JSON 50734227.27274523 ns/iter 41094405.55555466 ns/iter 1.23
Schema_Format_ISO_Language_To_JSON 203162500.00003794 ns/iter 168454400.0000301 ns/iter 1.21
Schema_Bundle_Meta_2020_12 2853903.2128531444 ns/iter 2194298.840580866 ns/iter 1.30
Schema_Frame_Many_Resources_References 1534923899.999967 ns/iter 1198198899.9998522 ns/iter 1.28
EditorSchema_ForEditor_EmbeddedResources 30458587.99998314 ns/iter 23558846.42854887 ns/iter 1.29
URITemplateRouter_Create 37680.20844029435 ns/iter 28505.227208808774 ns/iter 1.32
URITemplateRouter_Match 218.5251874999494 ns/iter 169.53066964282877 ns/iter 1.29
URITemplateRouter_Match_BasePath 253.24669657357086 ns/iter 196.25377645121563 ns/iter 1.29
URITemplateRouterView_Restore 24695.96879499494 ns/iter 18108.08667934274 ns/iter 1.36
URITemplateRouterView_Match 173.65890624999128 ns/iter 121.23482142856444 ns/iter 1.43
URITemplateRouterView_Match_BasePath 186.23720666768352 ns/iter 140.22055624012427 ns/iter 1.33
URITemplateRouterView_Arguments 446.18106249998846 ns/iter 344.91259912280714 ns/iter 1.29
JSONL_Parse_Large 27715776.000004552 ns/iter 21399491.176473074 ns/iter 1.30
JSONL_Parse_Large_GZIP 27143761.53845968 ns/iter 20872606.250001978 ns/iter 1.30
HTML_Build_Table_100000 92922614.28569353 ns/iter 72926722.22221579 ns/iter 1.27
HTML_Render_Table_100000 7881208.888887967 ns/iter 6633266.071428271 ns/iter 1.19
GZIP_Compress_ISO_Language_Set_3_Locations 44659656.25000478 ns/iter 33255285.714284625 ns/iter 1.34
GZIP_Decompress_ISO_Language_Set_3_Locations 11503148.437498111 ns/iter 8383705.357143104 ns/iter 1.37
GZIP_Compress_ISO_Language_Set_3_Schema 2544273.214285957 ns/iter 1908972.9222517554 ns/iter 1.33
GZIP_Decompress_ISO_Language_Set_3_Schema 673880.8035714377 ns/iter 455425.51908906444 ns/iter 1.48

This comment was automatically generated by workflow using github-action-benchmark.

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (macos/llvm)

Details
Benchmark suite Current: c98ca74 Previous: fc0dd4e Ratio
Regex_Lower_S_Or_Upper_S_Asterisk 2.3342081381018156 ns/iter 2.1758700960555273 ns/iter 1.07
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 2.1338697375253255 ns/iter 2.4799610717609344 ns/iter 0.86
Regex_Period_Asterisk 2.2203749382715054 ns/iter 2.210976701085108 ns/iter 1.00
Regex_Group_Period_Asterisk_Group 2.2204593495218763 ns/iter 2.156869569761622 ns/iter 1.03
Regex_Period_Plus 2.721938662417371 ns/iter 2.8680285218362456 ns/iter 0.95
Regex_Period 2.380522328766109 ns/iter 2.386481142066539 ns/iter 1.00
Regex_Caret_Period_Plus_Dollar 2.4833499006914983 ns/iter 2.515193781966196 ns/iter 0.99
Regex_Caret_Group_Period_Plus_Group_Dollar 2.5286122231360904 ns/iter 2.494503973712206 ns/iter 1.01
Regex_Caret_Period_Asterisk_Dollar 2.076014722053383 ns/iter 2.1347271084040518 ns/iter 0.97
Regex_Caret_Group_Period_Asterisk_Group_Dollar 2.1110195303648087 ns/iter 2.007789316662656 ns/iter 1.05
Regex_Caret_X_Hyphen 7.247351826528976 ns/iter 7.248044019728199 ns/iter 1.00
Regex_Period_Md_Dollar 21.05224030430366 ns/iter 19.49652279793936 ns/iter 1.08
Regex_Caret_Slash_Period_Asterisk 10.64943424055386 ns/iter 8.676199564590567 ns/iter 1.23
Regex_Caret_Period_Range_Dollar 2.1284216021775726 ns/iter 1.8480474626508747 ns/iter 1.15
Regex_Nested_Backtrack 32.67062059454539 ns/iter 24.96481625715579 ns/iter 1.31
JSON_Array_Of_Objects_Unique 514.5361813263746 ns/iter 368.8425373687705 ns/iter 1.40
JSON_Parse_1 6055.121265636973 ns/iter 4107.651746291446 ns/iter 1.47
JSON_Parse_Real 10440.945412629439 ns/iter 7888.737981436835 ns/iter 1.32
JSON_Parse_Decimal 11944.696507922088 ns/iter 8781.768390968156 ns/iter 1.36
JSON_Parse_Schema_ISO_Language 6141662.213591208 ns/iter 4262583.3374226475 ns/iter 1.44
JSON_Fast_Hash_Helm_Chart_Lock 91.36024139202246 ns/iter 62.41327795118307 ns/iter 1.46
JSON_Equality_Helm_Chart_Lock 184.00384836866553 ns/iter 166.34370980140045 ns/iter 1.11
JSON_Divisible_By_Decimal 213.2738505951838 ns/iter 213.37477226343762 ns/iter 1.00
JSON_String_Equal/10 7.279309142499313 ns/iter 8.893539352801282 ns/iter 0.82
JSON_String_Equal/100 8.75253773375606 ns/iter 7.976036381041551 ns/iter 1.10
JSON_String_Equal_Small_By_Perfect_Hash/10 0.8835931891287667 ns/iter 0.9150517829378911 ns/iter 0.97
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 3.716229322789292 ns/iter 4.203410417674377 ns/iter 0.88
JSON_String_Fast_Hash/10 2.8955634460104016 ns/iter 2.6684732244383227 ns/iter 1.09
JSON_String_Fast_Hash/100 2.4259574125171324 ns/iter 2.2123206535429283 ns/iter 1.10
JSON_String_Key_Hash/10 1.7025669879336687 ns/iter 1.5029791700549293 ns/iter 1.13
JSON_String_Key_Hash/100 2.546083329860904 ns/iter 2.414293652470945 ns/iter 1.05
JSON_Object_Defines_Miss_Same_Length 2.7228869882098974 ns/iter 2.6772560497118087 ns/iter 1.02
JSON_Object_Defines_Miss_Too_Small 3.203526239547523 ns/iter 2.752055649881979 ns/iter 1.16
JSON_Object_Defines_Miss_Too_Large 2.8444107876607942 ns/iter 3.3135616641695806 ns/iter 0.86
Pointer_Object_Traverse 15.652278828996513 ns/iter 18.88847315306521 ns/iter 0.83
Pointer_Object_Try_Traverse 33.102627042200325 ns/iter 27.3919463640011 ns/iter 1.21
Pointer_Push_Back_Pointer_To_Weak_Pointer 207.45476771943837 ns/iter 210.57890995803567 ns/iter 0.99
Pointer_Walker_Schema_ISO_Language 6736978.862319199 ns/iter 5931700.630251251 ns/iter 1.14
Pointer_Maybe_Tracked_Deeply_Nested/0 1177799.4835590126 ns/iter 1814966.8972433745 ns/iter 0.65
Pointer_Maybe_Tracked_Deeply_Nested/1 1892143.7540600537 ns/iter 2509795.1586827864 ns/iter 0.75
Pointer_Position_Tracker_Get_Deeply_Nested 512.5330420000864 ns/iter 453.2496843457487 ns/iter 1.13
Schema_Frame_WoT_References 8269818.000000626 ns/iter 6290004.796460984 ns/iter 1.31
Schema_Frame_OMC_References 38842561.42105427 ns/iter 40563511.55554694 ns/iter 0.96
Schema_Frame_OMC_Locations 31419496.047614563 ns/iter 33975087.50000498 ns/iter 0.92
Schema_Frame_ISO_Language_Locations 102339520.83334923 ns/iter 101779597.16664493 ns/iter 1.01
Schema_Frame_KrakenD_References 79937388.9166759 ns/iter 57934685.22220893 ns/iter 1.38
Schema_Frame_KrakenD_Reachable 721662874.9999927 ns/iter 581761248.9997828 ns/iter 1.24
Schema_Iterator_ISO_Language 3955479.4644558034 ns/iter 3582010.8544062017 ns/iter 1.10
Schema_Frame_ISO_Language_Locations_To_JSON 143613229.24997923 ns/iter 119685265.62498027 ns/iter 1.20
Schema_Tracker_ISO_Language 8243267.140185402 ns/iter 5127259.999999296 ns/iter 1.61
Schema_Tracker_ISO_Language_To_JSON 20556376.20587865 ns/iter 15023790.760867836 ns/iter 1.37
Schema_Format_ISO_Language_To_JSON 120558408.60007265 ns/iter 94353453.24999389 ns/iter 1.28
Schema_Bundle_Meta_2020_12 1878520.5534629694 ns/iter 1347343.862669721 ns/iter 1.39
Schema_Frame_Many_Resources_References 518725312.5000098 ns/iter 345922416.999997 ns/iter 1.50
EditorSchema_ForEditor_EmbeddedResources 15601089.794886436 ns/iter 13610726.214291649 ns/iter 1.15
URITemplateRouter_Create 27716.454567923553 ns/iter 25716.195488727666 ns/iter 1.08
URITemplateRouter_Match 186.29003541426067 ns/iter 213.3811895320508 ns/iter 0.87
URITemplateRouter_Match_BasePath 231.6078411897479 ns/iter 198.9083536710572 ns/iter 1.16
URITemplateRouterView_Restore 16774.54377604162 ns/iter 12181.761774216775 ns/iter 1.38
URITemplateRouterView_Match 162.68404307854027 ns/iter 186.0328181769129 ns/iter 0.87
URITemplateRouterView_Match_BasePath 198.9399836559424 ns/iter 164.7478832017283 ns/iter 1.21
URITemplateRouterView_Arguments 495.02690121973575 ns/iter 709.650874999852 ns/iter 0.70
JSONL_Parse_Large 17191381.488889117 ns/iter 24835261.363636386 ns/iter 0.69
JSONL_Parse_Large_GZIP 16344127.243244017 ns/iter 17029566.89473467 ns/iter 0.96
HTML_Build_Table_100000 84474345.28573337 ns/iter 99186143.55554685 ns/iter 0.85
HTML_Render_Table_100000 6661021.750000587 ns/iter 5169858.620688658 ns/iter 1.29
GZIP_Compress_ISO_Language_Set_3_Locations 44285171.52941555 ns/iter 33895263.157893695 ns/iter 1.31
GZIP_Decompress_ISO_Language_Set_3_Locations 8024961.399999148 ns/iter 6981475.071429242 ns/iter 1.15
GZIP_Compress_ISO_Language_Set_3_Schema 2019949.203703096 ns/iter 1718416.8975071772 ns/iter 1.18
GZIP_Decompress_ISO_Language_Set_3_Schema 387073.15921967174 ns/iter 415859.5247759021 ns/iter 0.93

This comment was automatically generated by workflow using github-action-benchmark.

@jviotti jviotti merged commit 0f99990 into main May 19, 2026
13 checks passed
@jviotti jviotti deleted the unc-paths branch May 19, 2026 22:20
Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (linux/gcc)

Details
Benchmark suite Current: c98ca74 Previous: fc0dd4e Ratio
GZIP_Compress_ISO_Language_Set_3_Locations 38325442.33334071 ns/iter 41092965.47058501 ns/iter 0.93
GZIP_Decompress_ISO_Language_Set_3_Locations 4806484.662067932 ns/iter 4446788.2611466255 ns/iter 1.08
GZIP_Compress_ISO_Language_Set_3_Schema 2069592.4985158062 ns/iter 2337370.9733338426 ns/iter 0.89
GZIP_Decompress_ISO_Language_Set_3_Schema 395249.77075096813 ns/iter 298099.1614705099 ns/iter 1.33
HTML_Build_Table_100000 60213775.16666841 ns/iter 65206199.90909505 ns/iter 0.92
HTML_Render_Table_100000 1927822.8821916208 ns/iter 1890114.128767368 ns/iter 1.02
JSONL_Parse_Large 13109697.471699685 ns/iter 12533632.1428579 ns/iter 1.05
JSONL_Parse_Large_GZIP 14233472.428570017 ns/iter 13693608.882352004 ns/iter 1.04
URITemplateRouter_Create 29544.42521412595 ns/iter 29926.452942935874 ns/iter 0.99
URITemplateRouter_Match 185.4526145814832 ns/iter 172.85430403386772 ns/iter 1.07
URITemplateRouter_Match_BasePath 211.31753024856744 ns/iter 203.18457155196563 ns/iter 1.04
URITemplateRouterView_Restore 7948.699875578087 ns/iter 8433.871726469913 ns/iter 0.94
URITemplateRouterView_Match 141.23215332787177 ns/iter 132.28218150461765 ns/iter 1.07
URITemplateRouterView_Match_BasePath 163.13649396347165 ns/iter 160.08231345496407 ns/iter 1.02
URITemplateRouterView_Arguments 484.25725305950107 ns/iter 471.2556006938783 ns/iter 1.03
EditorSchema_ForEditor_EmbeddedResources 14228098.591836303 ns/iter 13984147.14001774 ns/iter 1.02
Schema_Frame_WoT_References 5447473.543306942 ns/iter 5467437.9844954265 ns/iter 1.00
Schema_Frame_OMC_References 22323744.09677798 ns/iter 22684151.38709931 ns/iter 0.98
Schema_Frame_OMC_Locations 20724054.411764026 ns/iter 21185333.424241573 ns/iter 0.98
Schema_Frame_ISO_Language_Locations 102711415.14285123 ns/iter 99685595.14287075 ns/iter 1.03
Schema_Frame_KrakenD_References 40151738.29412454 ns/iter 41525869.41175768 ns/iter 0.97
Schema_Frame_KrakenD_Reachable 527545342.99992883 ns/iter 565802624.0000708 ns/iter 0.93
Schema_Iterator_ISO_Language 3350258.6028704895 ns/iter 3300672.195348662 ns/iter 1.02
Schema_Frame_ISO_Language_Locations_To_JSON 215149416.33328512 ns/iter 226436906.33329546 ns/iter 0.95
Schema_Tracker_ISO_Language 4600085.038960769 ns/iter 4413580.320754093 ns/iter 1.04
Schema_Tracker_ISO_Language_To_JSON 22322295.612903256 ns/iter 21926217.250005208 ns/iter 1.02
Schema_Format_ISO_Language_To_JSON 110264195.1666404 ns/iter 104340030.57142556 ns/iter 1.06
Schema_Bundle_Meta_2020_12 1815749.5116941968 ns/iter 1786890.020196786 ns/iter 1.02
Schema_Frame_Many_Resources_References 386841322.0000093 ns/iter 377987684.499999 ns/iter 1.02
Pointer_Object_Traverse 28.20606365488298 ns/iter 33.115014736451485 ns/iter 0.85
Pointer_Object_Try_Traverse 22.45753597316082 ns/iter 22.12756965090643 ns/iter 1.01
Pointer_Push_Back_Pointer_To_Weak_Pointer 169.6670793029202 ns/iter 177.40122171594132 ns/iter 0.96
Pointer_Walker_Schema_ISO_Language 3313615.976303567 ns/iter 3550497.9340101564 ns/iter 0.93
Pointer_Maybe_Tracked_Deeply_Nested/0 1593237.3318081433 ns/iter 1535044.6403508096 ns/iter 1.04
Pointer_Maybe_Tracked_Deeply_Nested/1 1793352.2982008925 ns/iter 1727267.453201882 ns/iter 1.04
Pointer_Position_Tracker_Get_Deeply_Nested 554.3178827874675 ns/iter 414.27762983281747 ns/iter 1.34
JSON_Array_Of_Objects_Unique 411.02128105905166 ns/iter 431.53883497539715 ns/iter 0.95
JSON_Parse_1 7878.222184729953 ns/iter 7816.829401334337 ns/iter 1.01
JSON_Parse_Real 11900.775760382687 ns/iter 11650.569442093441 ns/iter 1.02
JSON_Parse_Decimal 17733.951558586727 ns/iter 16520.604259638432 ns/iter 1.07
JSON_Parse_Schema_ISO_Language 4635605.185431447 ns/iter 4563267.385620314 ns/iter 1.02
JSON_Fast_Hash_Helm_Chart_Lock 67.26395804331952 ns/iter 61.91594706052464 ns/iter 1.09
JSON_Equality_Helm_Chart_Lock 171.7192646215414 ns/iter 190.22376892919104 ns/iter 0.90
JSON_Divisible_By_Decimal 237.65480827467584 ns/iter 231.08414442644926 ns/iter 1.03
JSON_String_Equal/10 6.774633302956511 ns/iter 6.824683747652588 ns/iter 0.99
JSON_String_Equal/100 7.435409789312351 ns/iter 7.531324189970184 ns/iter 0.99
JSON_String_Equal_Small_By_Perfect_Hash/10 0.6252177303162838 ns/iter 0.7120646290453883 ns/iter 0.88
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 25.20537475896134 ns/iter 22.02300938759695 ns/iter 1.14
JSON_String_Fast_Hash/10 1.5584831618718062 ns/iter 1.7595140259386939 ns/iter 0.89
JSON_String_Fast_Hash/100 1.5577480714973777 ns/iter 1.760614336866667 ns/iter 0.88
JSON_String_Key_Hash/10 1.2471589983646783 ns/iter 1.0880398473235355 ns/iter 1.15
JSON_String_Key_Hash/100 12.447910077537806 ns/iter 15.08471524851233 ns/iter 0.83
JSON_Object_Defines_Miss_Same_Length 3.426289373394153 ns/iter 3.8748801900419982 ns/iter 0.88
JSON_Object_Defines_Miss_Too_Small 3.7404738770163894 ns/iter 4.237369900374012 ns/iter 0.88
JSON_Object_Defines_Miss_Too_Large 3.114941662326685 ns/iter 3.521919995606561 ns/iter 0.88
Regex_Lower_S_Or_Upper_S_Asterisk 0.6227252350185664 ns/iter 0.704307519160345 ns/iter 0.88
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 0.622842802916376 ns/iter 0.7062490855727792 ns/iter 0.88
Regex_Period_Asterisk 0.9391954511688322 ns/iter 1.055696364574927 ns/iter 0.89
Regex_Group_Period_Asterisk_Group 0.9355249278419526 ns/iter 1.0563926489257243 ns/iter 0.89
Regex_Period_Plus 0.6232564404629372 ns/iter 0.7040847492030046 ns/iter 0.89
Regex_Period 0.6237823519901898 ns/iter 0.703960355737343 ns/iter 0.89
Regex_Caret_Period_Plus_Dollar 0.9341981082568575 ns/iter 1.0559295021790234 ns/iter 0.88
Regex_Caret_Group_Period_Plus_Group_Dollar 0.9339575086402019 ns/iter 1.0602553032938513 ns/iter 0.88
Regex_Caret_Period_Asterisk_Dollar 0.6763911157702537 ns/iter 0.7039777254462968 ns/iter 0.96
Regex_Caret_Group_Period_Asterisk_Group_Dollar 0.6262872806303335 ns/iter 0.7041508141383516 ns/iter 0.89
Regex_Caret_X_Hyphen 4.05582731786687 ns/iter 3.869641106630043 ns/iter 1.05
Regex_Period_Md_Dollar 27.98914428946954 ns/iter 32.781980402409644 ns/iter 0.85
Regex_Caret_Slash_Period_Asterisk 4.669167165010081 ns/iter 4.572277343922315 ns/iter 1.02
Regex_Caret_Period_Range_Dollar 0.7823442284335336 ns/iter 0.8439348331187605 ns/iter 0.93
Regex_Nested_Backtrack 36.11576452154393 ns/iter 38.31286894632375 ns/iter 0.94

This comment was automatically generated by workflow using github-action-benchmark.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant