Skip to content

Do not restrict parallelism on Makefile #2396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jviotti merged 1 commit into from
May 21, 2026
+1 −1
Merged

Do not restrict parallelism on Makefile #2396

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ configure: .always

compile: .always
$(CMAKE) --build ./build --config $(PRESET) --target clang_format
$(CMAKE) --build ./build --config $(PRESET) --parallel 4
$(CMAKE) --build ./build --config $(PRESET)
Copy link
Copy Markdown

@augmentcode augmentcode Bot May 21, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Calling cmake --build without --parallel can make some generators (e.g., Unix Makefiles / MSBuild) fall back to single-threaded builds unless CMAKE_BUILD_PARALLEL_LEVEL/MAKEFLAGS is set; is that intended here? If the goal is only to avoid capping jobs at 4, consider ensuring parallel builds remain enabled while still letting the level be user-controlled.

Severity: medium

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.

Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai Bot May 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1: Removing --parallel entirely makes the build single-threaded for Make generators. Use --parallel (without a number) to allow the native build tool's default parallelism instead of capping at 4.

Prompt for AI agents 
Check if this issue is valid — if so, understand the root cause and fix it. At Makefile, line 22:

<comment>Removing `--parallel` entirely makes the build single-threaded for Make generators. Use `--parallel` (without a number) to allow the native build tool's default parallelism instead of capping at 4.</comment>

<file context>
@@ -19,7 +19,7 @@ configure: .always
 compile: .always
 	$(CMAKE) --build ./build --config $(PRESET) --target clang_format
-	$(CMAKE) --build ./build --config $(PRESET) --parallel 4
+	$(CMAKE) --build ./build --config $(PRESET)
 	$(CMAKE) --install ./build --prefix ./build/dist --config $(PRESET) --verbose \
 		--component sourcemeta_core
</file context>
Suggested change
$(CMAKE) --build ./build --config $(PRESET)
$(CMAKE) --build ./build --config $(PRESET) --parallel

$(CMAKE) --install ./build --prefix ./build/dist --config $(PRESET) --verbose \
--component sourcemeta_core
$(CMAKE) --install ./build --prefix ./build/dist --config $(PRESET) --verbose \
Expand Down
Loading