Support websiteUrl and description in MCP server info#939
Conversation
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
🤖 Augment PR SummarySummary: This PR adds support for MCP Changes:
Technical Notes: Fields are only emitted when the negotiated protocol version supports them. 🤖 Was this summary useful? React with 👍 or 👎 |
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
| ? std::string_view{configuration.html->description} | ||
| : std::string_view{}}); | ||
| initialize_ingredients.push_back(sourcemeta::core::JSON{ | ||
| configuration.html.has_value() ? std::string_view{configuration.url} |
There was a problem hiding this comment.
serverInfo.websiteUrl is derived from configuration.url without trimming a trailing /, while template_uri is normalized to remove it. If the configured url ends with /, this can lead to inconsistent URLs being advertised (and potentially brittle tests/clients).
Severity: medium
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Benchmark Index (community)
Details
| Benchmark suite | Current: a25bb1b | Previous: c62ef5e | Ratio |
|---|---|---|---|
Add one schema (0 existing) |
282 ms |
287 ms |
0.98 |
Add one schema (100 existing) |
26 ms |
25 ms |
1.04 |
Add one schema (1000 existing) |
87 ms |
78 ms |
1.12 |
Add one schema (10000 existing) |
839 ms |
997 ms |
0.84 |
Update one schema (1 existing) |
18 ms |
18 ms |
1 |
Update one schema (101 existing) |
26 ms |
25 ms |
1.04 |
Update one schema (1001 existing) |
90 ms |
78 ms |
1.15 |
Update one schema (10001 existing) |
705 ms |
646 ms |
1.09 |
Cached rebuild (1 existing) |
5 ms |
5 ms |
1 |
Cached rebuild (101 existing) |
8 ms |
7 ms |
1.14 |
Cached rebuild (1001 existing) |
35 ms |
27 ms |
1.30 |
Cached rebuild (10001 existing) |
273 ms |
276 ms |
0.99 |
Index 100 schemas |
129 ms |
113 ms |
1.14 |
Index 1000 schemas |
890 ms |
1034 ms |
0.86 |
Index 10000 schemas |
13182 ms |
13135 ms |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Benchmark Index (enterprise)
Details
| Benchmark suite | Current: a25bb1b | Previous: c62ef5e | Ratio |
|---|---|---|---|
Add one schema (0 existing) |
286 ms |
295 ms |
0.97 |
Add one schema (100 existing) |
29 ms |
28 ms |
1.04 |
Add one schema (1000 existing) |
87 ms |
84 ms |
1.04 |
Add one schema (10000 existing) |
890 ms |
781 ms |
1.14 |
Update one schema (1 existing) |
20 ms |
22 ms |
0.91 |
Update one schema (101 existing) |
27 ms |
29 ms |
0.93 |
Update one schema (1001 existing) |
81 ms |
85 ms |
0.95 |
Update one schema (10001 existing) |
661 ms |
709 ms |
0.93 |
Cached rebuild (1 existing) |
6 ms |
6 ms |
1 |
Cached rebuild (101 existing) |
8 ms |
9 ms |
0.89 |
Cached rebuild (1001 existing) |
30 ms |
30 ms |
1 |
Cached rebuild (10001 existing) |
269 ms |
255 ms |
1.05 |
Index 100 schemas |
123 ms |
125 ms |
0.98 |
Index 1000 schemas |
1208 ms |
1186 ms |
1.02 |
Index 10000 schemas |
13295 ms |
13906 ms |
0.96 |
This comment was automatically generated by workflow using github-action-benchmark.
1 participant
Signed-off-by: Juan Cruz Viotti jv@jviotti.com