Skip to content

Always require a name in MCP tool content responses#943

Merged
jviotti merged 1 commit into
mainfrom
resource-link-names
May 25, 2026
Merged

Always require a name in MCP tool content responses#943
jviotti merged 1 commit into
mainfrom
resource-link-names

Conversation

@jviotti
Copy link
Copy Markdown
Member

@jviotti jviotti commented May 25, 2026

Signed-off-by: Juan Cruz Viotti jv@jviotti.com

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 10 files

Re-trigger cubic

@augmentcode
Copy link
Copy Markdown

augmentcode Bot commented May 25, 2026

🤖 Augment PR Summary

Summary: This PR updates MCP tool-call responses so every resource_link content block always includes a name, aligning with the MCP specification.

Changes:

  • Updated tool actions that emit schema links to provide a fallback `name` (using the schema path/relative URI when no title is available).
  • Adjusted dependency-tree tool output to pass an explicit `name` for generated resource links.
  • Updated the MCP tools/call response schema to require `name` for `resource_link` blocks.
  • Refreshed enterprise E2E Hurl assertions to expect `name` fields (and updated schema size expectations accordingly).

Technical Notes: For older MCP versions that don’t support resource_link blocks, mcp_make_resource_link renders a text line; the new name values influence that legacy text format too.

🤖 Was this summary useful? React with 👍 or 👎

Copy link
Copy Markdown

@augmentcode augmentcode Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark Index (community)

Details
Benchmark suite Current: 057ea62 Previous: 4823835 Ratio
Add one schema (0 existing) 286 ms 287 ms 1.00
Add one schema (100 existing) 27 ms 26 ms 1.04
Add one schema (1000 existing) 88 ms 79 ms 1.11
Add one schema (10000 existing) 788 ms 930 ms 0.85
Update one schema (1 existing) 19 ms 19 ms 1
Update one schema (101 existing) 28 ms 26 ms 1.08
Update one schema (1001 existing) 89 ms 78 ms 1.14
Update one schema (10001 existing) 742 ms 664 ms 1.12
Cached rebuild (1 existing) 6 ms 5 ms 1.20
Cached rebuild (101 existing) 8 ms 7 ms 1.14
Cached rebuild (1001 existing) 32 ms 27 ms 1.19
Cached rebuild (10001 existing) 287 ms 304 ms 0.94
Index 100 schemas 114 ms 114 ms 1
Index 1000 schemas 895 ms 904 ms 0.99
Index 10000 schemas 13232 ms 13446 ms 0.98

This comment was automatically generated by workflow using github-action-benchmark.

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark Index (enterprise)

Details
Benchmark suite Current: 057ea62 Previous: 4823835 Ratio
Add one schema (0 existing) 295 ms 219 ms 1.35
Add one schema (100 existing) 30 ms 24 ms 1.25
Add one schema (1000 existing) 89 ms 75 ms 1.19
Add one schema (10000 existing) 707 ms 772 ms 0.92
Update one schema (1 existing) 23 ms 80 ms 0.29
Update one schema (101 existing) 31 ms 24 ms 1.29
Update one schema (1001 existing) 90 ms 92 ms 0.98
Update one schema (10001 existing) 721 ms 789 ms 0.91
Cached rebuild (1 existing) 7 ms 5 ms 1.40
Cached rebuild (101 existing) 10 ms 8 ms 1.25
Cached rebuild (1001 existing) 33 ms 25 ms 1.32
Cached rebuild (10001 existing) 277 ms 224 ms 1.24
Index 100 schemas 124 ms 94 ms 1.32
Index 1000 schemas 1040 ms 1183 ms 0.88
Index 10000 schemas 13737 ms 20401 ms 0.67

This comment was automatically generated by workflow using github-action-benchmark.

@jviotti jviotti merged commit a78c41d into main May 25, 2026
5 checks passed
@jviotti jviotti deleted the resource-link-names branch May 25, 2026 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant