Updated docker compose#5
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Docker Compose configuration to improve code organization and standardize formatting. The changes focus on removing volume mounts and adjusting YAML syntax.
- Removed local directory volume mounts from web, celery_worker, and celery_beat services
- Standardized YAML formatting for version string and healthcheck test array
- Cleaned up volume mount definitions that were previously used for development hot-reloading
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ports: | ||
| - "8000:8000" |
There was a problem hiding this comment.
Removing the .:/app volume mount from the web service eliminates hot-reloading during development. Developers will need to rebuild the container for every code change, significantly slowing down the development workflow. Consider keeping this volume mount for development or documenting this change in the PR description with rationale.
| command: celery -A {{ cookiecutter.project_slug }}.celery worker --loglevel=info | ||
| volumes: | ||
| - .:/app | ||
| environment: |
There was a problem hiding this comment.
Removing the .:/app volume mount from celery_worker eliminates hot-reloading for Celery task code changes. Developers will need to restart the container after every task modification, which hampers development efficiency. Consider retaining this mount for development environments.
| command: celery -A {{ cookiecutter.project_slug }}.celery beat --loglevel=info --scheduler django_celery_beat.schedulers:DatabaseScheduler | ||
| volumes: | ||
| - .:/app | ||
| environment: |
There was a problem hiding this comment.
Removing the .:/app volume mount from celery_beat means Celery Beat configuration changes require container restarts. This impacts development workflow when modifying periodic tasks. Consider keeping this volume mount for development purposes.
No description provided.