random.Next -> random.NextDouble in CultistCircle#745
Merged
ArchangelWTF merged 1 commit intosp-tarkov:4.1.x-devfrom Apr 5, 2026
Merged
random.Next -> random.NextDouble in CultistCircle#745ArchangelWTF merged 1 commit intosp-tarkov:4.1.x-devfrom
ArchangelWTF merged 1 commit intosp-tarkov:4.1.x-devfrom
Conversation
…Next(0,1) is always 0
CJ-SPT
approved these changes
Apr 4, 2026
ArchangelWTF
pushed a commit
that referenced
this pull request
Apr 10, 2026
…Next(0,1) is always 0 (#745)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
random.Next(0,1) will always return 0 because the maxValue is exclusive
BonusChanceMultiplier is a double (default 0.25)
random.NextDouble will return 0.0 (inclusive) - 1.0 (exclusive) which will properly check the BonusChanceMultiplier instead of always being true